Skip to content

🌱 drop dot-import nolints in tests#3000

Open
LouisLau-art wants to merge 1 commit intokubernetes-sigs:mainfrom
LouisLau-art:fix/dot-import-nolint
Open

🌱 drop dot-import nolints in tests#3000
LouisLau-art wants to merge 1 commit intokubernetes-sigs:mainfrom
LouisLau-art:fix/dot-import-nolint

Conversation

@LouisLau-art
Copy link
Copy Markdown

@LouisLau-art LouisLau-art commented Feb 6, 2026

Fixes #2995.

  • Update .golangci.yml so the "should not use dot imports" exclusion applies to all *_test.go and is scoped to ginkgo/gomega dot imports.
  • Remove redundant //nolint:revive comments from those import lines.

Test:

  • make lint-fast
  • make test-capo

@linux-foundation-easycla
Copy link
Copy Markdown

CLA Missing ID CLA Not Signed

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fabriziopandini for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 6, 2026

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit bf4b687
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/698546a580dcb800086bbf72
😎 Deploy Preview https://deploy-preview-3000--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @LouisLau-art!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 6, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @LouisLau-art. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 6, 2026
@LouisLau-art
Copy link
Copy Markdown
Author

/kind bug
/area provider/openstack
/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. area/provider/openstack Issues or PRs related to openstack provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Feb 6, 2026
Copy link
Copy Markdown
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!
Could you please check the CLA? You will need to sign this before we can merge.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 6, 2026
@lentzi90
Copy link
Copy Markdown
Contributor

lentzi90 commented Feb 6, 2026

/retitle 🌱 drop dot-import nolints in tests

@k8s-ci-robot k8s-ci-robot changed the title chore(lint): drop dot-import nolints in tests 🌱 drop dot-import nolints in tests Feb 6, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@LouisLau-art: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-openstack-test bf4b687 link true /test pull-cluster-api-provider-openstack-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lentzi90
Copy link
Copy Markdown
Contributor

lentzi90 commented Feb 6, 2026

Looks like the fix does not work yet.

@LouisLau-art
Copy link
Copy Markdown
Author

Thanks for checking. I’ve signed the CLA now. I’ll investigate why the latest fix still doesn’t work and push an update; if there’s a specific failing case you want me to prioritize, please point me to it.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 12, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/provider/openstack Issues or PRs related to openstack provider cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

Fix duplicate linter config and comments for dot imports

3 participants