🌱 drop dot-import nolints in tests#3000
🌱 drop dot-import nolints in tests#3000LouisLau-art wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Welcome @LouisLau-art! |
|
Hi @LouisLau-art. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/kind bug |
lentzi90
left a comment
There was a problem hiding this comment.
Thank you for the PR!
Could you please check the CLA? You will need to sign this before we can merge.
/ok-to-test
|
/retitle 🌱 drop dot-import nolints in tests |
|
@LouisLau-art: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Looks like the fix does not work yet. |
|
Thanks for checking. I’ve signed the CLA now. I’ll investigate why the latest fix still doesn’t work and push an update; if there’s a specific failing case you want me to prioritize, please point me to it. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes #2995.
.golangci.ymlso the "should not use dot imports" exclusion applies to all*_test.goand is scoped to ginkgo/gomega dot imports.//nolint:revivecomments from those import lines.Test: