⚠️ Add managedNetworks on OpenStackCluster#3122
Open
nikParasyr wants to merge 1 commit intokubernetes-sigs:mainfrom
Open
⚠️ Add managedNetworks on OpenStackCluster#3122nikParasyr wants to merge 1 commit intokubernetes-sigs:mainfrom
nikParasyr wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
size/L
Add managedNetworks on OpenStackCluster to group network related fields for when CAPO creates the cluster network.
nikParasyr
force-pushed
the
v1beta2_network
branch
from
23c9a80 to
13af52f
Compare
Contributor
Author
|
/test pull-cluster-api-provider-openstack-e2e-full-test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add managedNetworks on OpenStackCluster to group network related fields for when CAPO creates the cluster network.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2897
Special notes for your reviewer:
mtuis an acronym and i think the conventions there are to be fully capitalized on go struct, and lower letters in json. But not 100% sure.TODOs:
/hold