Reserve specific taint key prefixes #177
Reserve specific taint key prefixes #177sats-23 wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
|
Skipping CI for Draft Pull Request. |
✅ Deploy Preview for node-readiness-controller ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sats-23 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Sathvik <Sathvik.S@ibm.com>
| - message: reserved taint prefix 'readiness.k8s.io/system/*' is not | ||
| allowed | ||
| rule: '!self.key.startsWith(''readiness.k8s.io/system/'')' | ||
| - message: reserved taint prefix 'readiness.k8s.io/core/*' is not |
There was a problem hiding this comment.
@Priyankasaggu11929 identified in #155 that this is not a valid prefix format for taint (subprefix not allowed in Taints), so this behavior cannot be achieved without upstream change :(
Description
readiness.k8s.io/system/*readiness.k8s.io/core/*readiness.k8s.io/node/*readiness.k8s.io/device/*readiness.k8s.io/network/*readiness.k8s.io/storage/*Related Issue
Fixes #3
Type of Change
/kind feature
Testing
Checklist
make testpassesmake lintpassesDoes this PR introduce a user-facing change?
Doc #(issue)