Skip to content

Upgrade controller-runtime from v0.22.3 to v0.23.1#946

Open
dongjiang1989 wants to merge 2 commits intokubernetes-sigs:masterfrom
dongjiang1989:update-controller-runtime
Open

Upgrade controller-runtime from v0.22.3 to v0.23.1#946
dongjiang1989 wants to merge 2 commits intokubernetes-sigs:masterfrom
dongjiang1989:update-controller-runtime

Conversation

@dongjiang1989
Copy link
Copy Markdown
Member

What type of PR is this?

What this PR does / why we need it:

Bump controller-runtime to v0.23.1. Introduces new events API.

Release notes: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.23.0

Events Recorder API:
controller-runtime v0.23 migrates event recording toward the newer events.k8s.io API.

  • Update the reconciler Recorder field type/imports accordingly (new events recorder API).
  • If a controller emits events, update any Recorder.Event* calls to the new signature.
  • Ensure RBAC for Events targets the events.k8s.io API group when required.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Bump controller-runtime to `v0.23.1`. Introduces new events API.

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 27, 2026
@netlify
Copy link
Copy Markdown

netlify bot commented Jan 27, 2026

Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.

Name Link
🔨 Latest commit 0d58081
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-scheduler-plugins/deploys/69789bde3e1d42000892e906

@netlify
Copy link
Copy Markdown

netlify bot commented Jan 27, 2026

Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.

Name Link
🔨 Latest commit 6ad63d5
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-scheduler-plugins/deploys/69789abec3d5ae00084211d2

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dongjiang1989
Once this PR has been reviewed and has the lgtm label, please assign ffromani for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 27, 2026
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@dongjiang1989: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-scheduler-plugins-verify-build-master 0d58081 link true /test pull-scheduler-plugins-verify-build-master
pull-scheduler-plugins-verify 0d58081 link true /test pull-scheduler-plugins-verify
pull-scheduler-plugins-unit-test-master 0d58081 link true /test pull-scheduler-plugins-unit-test-master
pull-scheduler-plugins-integration-test-master 0d58081 link true /test pull-scheduler-plugins-integration-test-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dongjiang1989
Copy link
Copy Markdown
Member Author

Fixed in kubernetes/test-infra#36318

@Huang-Wei
Copy link
Copy Markdown
Contributor

@dongjiang1989 we have to postpone it until the k8s deps gets bumped first (next release), as https://github.com/kubernetes-sigs/controller-runtime/blob/v0.23.0/go.mod#L27 vendors k8s 1.35.

@dongjiang1989
Copy link
Copy Markdown
Member Author

@dongjiang1989 we have to postpone it until the k8s deps gets bumped first (next release), as https://github.com/kubernetes-sigs/controller-runtime/blob/v0.23.0/go.mod#L27 vendors k8s 1.35.

Thanks @Huang-Wei
Got it

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 11, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants