Upgrade controller-runtime from v0.22.3 to v0.23.1#946
Upgrade controller-runtime from v0.22.3 to v0.23.1#946dongjiang1989 wants to merge 2 commits intokubernetes-sigs:masterfrom
Conversation
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
✅ Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.
|
✅ Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dongjiang1989 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
|
@dongjiang1989: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Fixed in kubernetes/test-infra#36318 |
|
@dongjiang1989 we have to postpone it until the k8s deps gets bumped first (next release), as https://github.com/kubernetes-sigs/controller-runtime/blob/v0.23.0/go.mod#L27 vendors k8s 1.35. |
Thanks @Huang-Wei |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
What this PR does / why we need it:
Bump controller-runtime to
v0.23.1. Introduces new events API.Release notes: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.23.0
Events Recorder API:
controller-runtime v0.23 migrates event recording toward the newer
events.k8s.ioAPI.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?