Repository navigation
fix(deps): clear the seroval advisories in TanStack Router - #397
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #396.
Summary
Upgrade the compatible TanStack Router packages together and refresh only their dependency graph:
npm viewconfirms both top-level Router releases use router-core 1.171.39, whoseseroval: ^1.6.7range accepts the fixed release. No override is needed. Router-utils also requires the transitive diff upgrade from 8.0.4 to 9.0.0. Regenerate THIRD_PARTY_NOTICES; rebuilding the embedded UI produces identical committed assets.Evidence
just ui-auditreported both seroval advisories, GHSA-f86p-h4j2-7qgj and GHSA-9wx9-5pv9-3349.After:
just ui-auditreports no vulnerabilities, using only the two existing reviewed ignores in the unchanged Justfile.bun install --frozen-lockfilepasses without changes.just checkpasses on Ubuntu: Gate run. The separate race-test step was still running when this result was recorded.just checkattempted with writable local caches: script tests (177), Go tests, lint, dead-code checks, audit, embedded UI comparison, and notices check pass. Browser tests report 1,451 passed and nine failures in the existing app-lifecycle suite because the sandbox denies Node spawning/bin/ps(EPERM); the failed worker then hangs and must be terminated. This is not a passing local full gate. No unrelated code changes were made.just site-buildpasses separately, including generated documentation, diagram, and site artifact checks.checkrerun after documenting the sandbox failure; CI runs the full gate independently.Merge Danger
Door: two-way
Blast Radius: routing
Only Router-related dependency resolutions and the generated license inventory change. The existing audit exceptions remain unchanged.