Skip to content

Activate warnings -Wshadow -Wsign-conversion -Wfloat-equal and display logs#1967

Open
fspindle wants to merge 1 commit into
lagadic:masterfrom
fspindle:gha_warnings
Open

Activate warnings -Wshadow -Wsign-conversion -Wfloat-equal and display logs#1967
fspindle wants to merge 1 commit into
lagadic:masterfrom
fspindle:gha_warnings

Conversation

@fspindle

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.81%. Comparing base (315ebf1) to head (0c882ef).
⚠️ Report is 296 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1967      +/-   ##
==========================================
+ Coverage   48.79%   48.81%   +0.02%     
==========================================
  Files         532      532              
  Lines       69333    69396      +63     
  Branches    32426    32432       +6     
==========================================
+ Hits        33830    33878      +48     
- Misses      24924    31411    +6487     
+ Partials    10579     4107    -6472     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines +289 to +305
make -j$(nproc) install > make_install.log 2>&1
echo "VISP_DIR=$(pwd)/install" >> $GITHUB_ENV
echo $VISP_DIR
# Filter and group warnings into a separate file
grep -i "warning: " make_install.log > warnings.log
echo "Build output logged to make_install.log"
echo "Warnings logged to warnings.log"

- name: Show build logs
run: |
echo "=== Buils logs ==="
cat make_install.log

- name: Show warnings
run: |
echo "=== WARNINGS ==="
cat warnings.log

@s-trinh s-trinh Jun 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
make -j$(nproc) install > make_install.log 2>&1
echo "VISP_DIR=$(pwd)/install" >> $GITHUB_ENV
echo $VISP_DIR
# Filter and group warnings into a separate file
grep -i "warning: " make_install.log > warnings.log
echo "Build output logged to make_install.log"
echo "Warnings logged to warnings.log"
- name: Show build logs
run: |
echo "=== Buils logs ==="
cat make_install.log
- name: Show warnings
run: |
echo "=== WARNINGS ==="
cat warnings.log
make -j$(nproc) install 2>&1 | tee make_install.log
echo "VISP_DIR=$(pwd)/install" >> $GITHUB_ENV
echo $VISP_DIR
# Filter and group warnings into a separate file
grep -i "warning: " make_install.log > warnings.log
echo "Build output logged to make_install.log"
echo "Warnings logged to warnings.log"
- name: Show build logs
working-directory: build
run: |
echo "=== Buils logs ==="
cat make_install.log
- name: Show warnings
working-directory: build
run: |
echo "=== WARNINGS ==="
cat warnings.log

See: #1968

working-directory: build is missing.
Suggestion to use tee to still have an output when the GHA is running, to have an output in real-time when checking the CI.
If tee is used, Show build logs section could be dropped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants