Activate warnings -Wshadow -Wsign-conversion -Wfloat-equal and display logs#1967
Open
fspindle wants to merge 1 commit into
Open
Activate warnings -Wshadow -Wsign-conversion -Wfloat-equal and display logs#1967fspindle wants to merge 1 commit into
fspindle wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1967 +/- ##
==========================================
+ Coverage 48.79% 48.81% +0.02%
==========================================
Files 532 532
Lines 69333 69396 +63
Branches 32426 32432 +6
==========================================
+ Hits 33830 33878 +48
- Misses 24924 31411 +6487
+ Partials 10579 4107 -6472 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
s-trinh
reviewed
Jun 19, 2026
Comment on lines
+289
to
+305
| make -j$(nproc) install > make_install.log 2>&1 | ||
| echo "VISP_DIR=$(pwd)/install" >> $GITHUB_ENV | ||
| echo $VISP_DIR | ||
| # Filter and group warnings into a separate file | ||
| grep -i "warning: " make_install.log > warnings.log | ||
| echo "Build output logged to make_install.log" | ||
| echo "Warnings logged to warnings.log" | ||
|
|
||
| - name: Show build logs | ||
| run: | | ||
| echo "=== Buils logs ===" | ||
| cat make_install.log | ||
|
|
||
| - name: Show warnings | ||
| run: | | ||
| echo "=== WARNINGS ===" | ||
| cat warnings.log |
Contributor
There was a problem hiding this comment.
Suggested change
| make -j$(nproc) install > make_install.log 2>&1 | |
| echo "VISP_DIR=$(pwd)/install" >> $GITHUB_ENV | |
| echo $VISP_DIR | |
| # Filter and group warnings into a separate file | |
| grep -i "warning: " make_install.log > warnings.log | |
| echo "Build output logged to make_install.log" | |
| echo "Warnings logged to warnings.log" | |
| - name: Show build logs | |
| run: | | |
| echo "=== Buils logs ===" | |
| cat make_install.log | |
| - name: Show warnings | |
| run: | | |
| echo "=== WARNINGS ===" | |
| cat warnings.log | |
| make -j$(nproc) install 2>&1 | tee make_install.log | |
| echo "VISP_DIR=$(pwd)/install" >> $GITHUB_ENV | |
| echo $VISP_DIR | |
| # Filter and group warnings into a separate file | |
| grep -i "warning: " make_install.log > warnings.log | |
| echo "Build output logged to make_install.log" | |
| echo "Warnings logged to warnings.log" | |
| - name: Show build logs | |
| working-directory: build | |
| run: | | |
| echo "=== Buils logs ===" | |
| cat make_install.log | |
| - name: Show warnings | |
| working-directory: build | |
| run: | | |
| echo "=== WARNINGS ===" | |
| cat warnings.log |
See: #1968
working-directory: build is missing.
Suggestion to use tee to still have an output when the GHA is running, to have an output in real-time when checking the CI.
If tee is used, Show build logs section could be dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.