fix(testing): use AggregationBits.from_indices in multi-message proofs#813
Merged
tcoratger merged 1 commit intoJun 1, 2026
Merged
Conversation
The multi-message proof fixture still built a throwaway index list and called the conversion method that was removed when the index-to-bits logic moved onto the aggregation-bits constructor. The two changes landed in a merge order that left a call to the deleted method, so type checking failed on the main branch. Build the participation bitfield directly from the indices and drop the now unused import. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maincurrently fails type checking. The multi-message proof fixture callsValidatorIndices(...).to_aggregation_bits(), but that method was removed in #809 when the index→bits logic moved ontoAggregationBits.from_indices(...).The two PRs landed in an unlucky order:
ValidatorIndices.to_aggregation_bitsand updated every call site that existed at the time.verify_multi_message_proofs.pyusing the old API and merged after refactor(forks/lstar): small Pythonic cleanups #809 without a rebase, reintroducing a call to the now-deleted method.The result is a dangling call on
main:This applies the same fix #809 used everywhere else: build the participation bitfield directly from the indices via
AggregationBits.from_indices(validator_indices), and drop the now-unusedValidatorIndicesimport.Testing
just lint(ruff) — passedjust typecheck(ty) — passed (was failing onmainbefore this change)🤖 Generated with Claude Code