Refactor/cubit to notifier migration#42
Open
aydinguven-leancode wants to merge 14 commits into
Open
Conversation
…nagement Migrated from Cubit (Bloc) to value notifier. Removed dependencies: flutter_bloc, rx_dart, equatable, Changes are reflected on examples Changes are reflected on tests
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Albert221
reviewed
Jun 19, 2026
| FieldBuilder<String, ValidationError>( | ||
| field: context.read<SignupController>().email, | ||
| builder: (context, state) => TextFormField( | ||
| controller: context.read<SignupController>().email.textController, |
Member
There was a problem hiding this comment.
We already passed the field controller, why fetch it again? Please just add the field controller itself into the builder callback params.
cupofme
reviewed
Jun 19, 2026
cupofme
reviewed
Jun 19, 2026
Removed unnecessary //ignore commands Reverted version change on leancode_lint in example project Added debugLabel
….com/leancodepl/leancode_forms into refactor/cubit-to-notifier-migration
Examples modified FormGroupState is renamed into FormState
Examples and tests modified accordingly
Comment on lines
+306
to
+308
| /// **Maintainer note:** when adding a new field below, you MUST also add it | ||
| /// to both [operator ==] and [hashCode] at the bottom of the class, otherwise | ||
| /// the new field is silently invisible to dedup and structural comparisons. |
Member
There was a problem hiding this comment.
This note shouldn't be part of the dartdoc – it shouldn't show up in hover popups or in the generated docs:
(in AdvancedFormState too)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LMG-394
flutter_bloc,rx_dart, flutter_hooks,equatable`LMG-404
Migration.mdfile