Added FocusNode support in AdvancedTextFieldController#44
Open
aydinguven-leancode wants to merge 1 commit into
Open
Added FocusNode support in AdvancedTextFieldController#44aydinguven-leancode wants to merge 1 commit into
aydinguven-leancode wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds first-class focus management to the text field controller so consumers can bind a FocusNode directly and request focus without maintaining a custom subclass (as previously done in the example app).
Changes:
- Added an owned
FocusNodeandfocus()helper toAdvancedTextFieldController, and dispose the node with the controller lifecycle. - Added unit/widget tests covering
focusNodecreation, focus requests, and disposal behavior. - Simplified the example app by removing the dedicated
FocusableTextFieldControllerand wiring widgets tofield.focusNode.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/src/field/field_controller_test.dart | Adds coverage for AdvancedTextFieldController focus node behavior. |
| lib/src/field/advanced_text_field_controller.dart | Introduces owned FocusNode, focus(), and disposal integration. |
| example/lib/widgets/form_text_field.dart | Binds AppTextField to field.focusNode and removes focusable wrapper usage. |
| example/lib/screens/scroll_form.dart | Switches example fields to AdvancedTextFieldController and uses focus() for navigation. |
| example/lib/controllers/focusable_text_field_controller.dart | Removes now-redundant controller subclass. |
| CHANGELOG.md | Documents the newly supported focus-management API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /// [textController] and [focusNode]; programmatic changes via [setValue] / | ||
| /// [reset] / [clearErrors] propagate to the text controller, and user input on | ||
| /// the text controller propagates back to the field state. | ||
| class AdvancedTextFieldController<E extends Object> extends AdvancedFieldController< String, E> { |
Comment on lines
+28
to
+29
| /// The [FocusNode] bound to this field. Lifecycle owned by this class | ||
| /// don;t dispose externally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.