Standardize and fix CUDA artifact naming and packaging#11
Merged
Conversation
Add -DGGML_CUDA=ON and -DCMAKE_CUDA_COMPILER explicitly to the Linux CUDA cmake invocation so CUDA is actually compiled instead of silently falling back to CPU when auto-detection fails. Widen the ggml artifact collection from libggml-cuda.so only to libggml*.so* (Linux) and ggml*.dll (Windows) to capture all ggml shared libraries (core, base backend, cuda backend) regardless of where cmake places them in the build tree. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Fix cuda bundling
kenvandine
approved these changes
Jun 5, 2026
Member
kenvandine
left a comment
kenvandine
left a comment
There was a problem hiding this comment.
This looks much better, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the build workflow to improve CUDA and GGML library handling for both Linux and Windows builds. The changes ensure that all relevant GGML shared libraries and DLLs are properly included in the build output, and that CUDA settings are more explicitly defined in the CMake configuration.
Build system improvements:
GGML_CUDAoption and explicitly set the CUDA compiler path in the CMake configuration to ensure CUDA support is properly built.libggml*.so*on Linux,ggml*.dllon Windows) in the build output, instead of only copying the CUDA-specific library. [1] [2]