Repository navigation
Keep valid semi-specific peptides from long cleavage products - #223
Merged
Merged
Conversation
Owner
|
Thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This returns
[]before the change. The expected result is[(0, 'PEP'), (0, 'PEPT'), (0, 'PEPTI'), (3, 'TIDEK'), (4, 'IDEK'), (5, 'DEK')].Generate semi-specific prefixes and suffixes independently of whether the full cleavage product satisfies the length limit. Include prefixes whose length equals
max_length. Two regression tests cover exact bounds and preserve the order and duplicates of the equivalent unbounded result followed by a length filter, including missed cleavages.An independent enumeration on four UniProt albumin/hemoglobin sequences agrees with all 80 digestion and precursor-planning configurations after the change; 42 configurations previously omitted candidates. All 38 previously correct records remain identical. Another 2,880 constructed short-sequence cases agree with exhaustive interval enumeration.
Validation uses Python 3.10/NumPy 1.26 and Python 3.12/NumPy 2.5, the project's per-file test commands, and an isolated wheel replay. The separate isoelectric-point correction also composes cleanly and preserves these results.
All 27 project CI test files succeed on each dependency profile (491 tests, including one live-PostgreSQL service skip).