Repository navigation
Allow users to pass group_id as part of data_location - #1083
Conversation
… kafka stream dataset.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
| host_port = parsed.netloc # "broker.example.org:9092" | ||
| topic = parsed.path.lstrip("/") # "my-topic" | ||
| if "/" in topic: | ||
| topic, group_id = topic.split("/", 1) # "my-topic", "my-group" |
There was a problem hiding this comment.
Note that it is generally forbidden to use "/" in a kafka topic name, but slashes are NOT forbidden in group ids. So it should be safe to simply split on the first "/" character and assume that the left side is topic and the right side is group_id.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1083 +/- ##
=======================================
Coverage 71.56% 71.57%
=======================================
Files 93 93
Lines 9309 9312 +3
=======================================
+ Hits 6662 6665 +3
Misses 2647 2647 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Allow users to pass
group_idas part of data_location when creating kafka stream dataset.