Add CDC+BST catch-up dedup hook in SourceBasedDeduper#1023
Open
mittalprince wants to merge 1 commit into
Open
Conversation
mittalprince
force-pushed
the
add-cdc-bst-catchup-dedup-hook
branch
from
ab7e7a3 to
c0add3d
Compare
1. SourceBasedDeduper: add protected isCdcBstStreamCaughtUp(Datastream) hook (returns false by default) so subclasses can short-circuit the 6-hour grace window when consumer-group lag has already drained. Update findDedupCandidateForNewCdcOnlyStream to allow dedup if either the window has expired OR the hook returns true. 2. TestSourceBasedDeduper: add two tests covering the caught-up and not-caught-up hook paths.
mittalprince
force-pushed
the
add-cdc-bst-catchup-dedup-hook
branch
from
c0add3d to
0543475
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isCdcBstStreamCaughtUp(Datastream)inSourceBasedDeduper(returns false by default) that subclasses can override with a real consumer group lag checkfindDedupCandidateForNewCdcOnlyStreamto allow CDC-only stream to dedup against a CDC+BST stream if the grace window has expired or the hook returns trueTest plan
TestSourceBasedDedupertests passtestCdcOnlyNewVsExistingCdcBstCaughtUpEarly— verifies dedup succeeds before grace window when hook returns truetestCdcOnlyNewVsExistingCdcBstNotCaughtUp— verifies dedup is blocked when hook returns false