fix(network): prevent ping-pong switching in multi-NIC scenario#571
Merged
Conversation
Replace m_isSwitching flag with a cooldown timer in InternetChecker to avoid frequent route switching. The cooldown starts at the beginning of switchInternetAccess() and lasts for connectivityCheckInterval, covering both the switching process and post-switch stabilization. Add a proactive accessibility check at the entry of switchInternetAccess() to verify the primary connection before initiating a switch, skipping unnecessary switching when the current connection is already functional. Restore realStartCheck() to its original structure, removing the snapshot logic (m_checkStartPrimaryId) that checked for primary connection changes during the check, since the proactive check in InternetChecker handles this case more cleanly. Also fix reapplyConnection to pass the correct flags parameter. PMS:BUG-351163
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
caixr23
approved these changes
Jun 29, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: caixr23, ut003640 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace m_isSwitching flag with a cooldown timer in InternetChecker to avoid frequent route switching. The cooldown starts at the beginning of switchInternetAccess() and lasts for connectivityCheckInterval, covering both the switching process and post-switch stabilization.
Add a proactive accessibility check at the entry of switchInternetAccess() to verify the primary connection before initiating a switch, skipping unnecessary switching when the current connection is already functional.
Restore realStartCheck() to its original structure, removing the snapshot logic (m_checkStartPrimaryId) that checked for primary connection changes during the check, since the proactive check in InternetChecker handles this case more cleanly.
Also fix reapplyConnection to pass the correct flags parameter.
PMS:BUG-351163