Skip to content

fix(renovate): add allowedVersions rules for packages that broke CI in #746 - #748

Merged
ericcurtin merged 1 commit into
llmmanorg:mainfrom
lmilbaum:fix/pr-746-audit-fixes
Nov 1, 2026
Merged

ericcurtin merged 1 commit into
llmmanorg:mainfrom
lmilbaum:fix/pr-746-audit-fixes

Conversation

@lmilbaum

@lmilbaum lmilbaum commented Nov 1, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Adds allowedVersions block rules to renovate.json for every package that caused the two CI failures in the grouped dependency update (#746). Renovate will use these rules the next time it regenerates the grouped update, so only compatible versions are proposed.

Android (remove each rule once the corresponding migration is done):

  • Gradle wrapper <9.0.0 — AGP 8.x requires Gradle 8.x; Gradle 9.6+ removed an internal API AGP 8.x depends on
  • org.jetbrains.kotlin.android <2.2.0 — Kotlin 2.2+ promotes kotlinOptions {} to a compile error (~37 call sites)
  • androidx.core:core-ktx <=1.15.0 — 1.16+ requires minCompileSdk=37 and AGP 9.1.0
  • androidx.activity:activity-ktx <=1.9.3 — 1.10+ requires minCompileSdk=36

npm (remove when Expo SDK 58 block is lifted):

  • react/react-dom <=19.2.3 — Expo SDK 57 pins react at 19.2.3; bumping breaks jest-expo 57 react-test-renderer peer
  • react-native-webview <14.0.0 — 14.x introduces TypeScript errors in components/terminal/Terminal.tsx
  • react-native-keyboard-controller <=1.21.9 — Expo SDK 57 bundledNativeModules pin
  • react-native-screens ~4.26.0 — Expo SDK 57 bundledNativeModules pin
  • react-native-safe-area-context ~5.7.0 — Expo SDK 57 bundledNativeModules pin
  • jest/@types/jest <30.0.0 — jest-expo 57 depends on jest 29 internals
  • @types/react ~19.2.0 — must match the react 19.2.3 pin above

Relationship to #746

PR #746 (renovate/all) remains open. Once this PR is merged, triggering a Renovate rebase on #746 (or closing and reopening it) will regenerate the dependency lockfiles with all the new caps applied, which should clear both CI failures.

🤖 Generated with Claude Code

@lmilbaum lmilbaum self-assigned this Nov 1, 2026
@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: QUIET
  • Plan: Advanced
  • Run ID: ae0296a8-241a-464a-aa8b-8f74f64b3d72
Commits

Reviewing files that changed from the base of the PR and between 5743bc9 and 8e4aafb.

Files selected for processing: 1
  • renovate.json

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Walkthrough

The Renovate configuration adds version constraints for selected Gradle, Java, Android, React Native, and Jest dependencies.

Changes: Renovate package rules

Layer / File(s) Summary
Package version constraints
renovate.json
Gradle rules constrain the wrapper, Kotlin, core-ktx, and activity-ktx; the GitHub Actions Java JDK rule allows version 17. npm rules constrain React, React DOM, webview, keyboard-controller, screens, safe-area-context, Jest, @types/jest, and @types/react.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Possibly related issues

  • llmmanorg/llmman#743 lists dependency updates for packages that this PR constrains in renovate.json.

Possibly related PRs

  • llmmanorg/llmman#739: This PR extends the Renovate configuration introduced in #739 with package version rules.
  • llmmanorg/llmman#747: Both PRs add Renovate version constraints for dependencies associated with grouped update #746.
Merge Risk: Minimal · up to 8e4aa

No actionable merge-blocking risk is established for these version constraints. Merge after normal configuration checks; the expected CI recovery remains unverified.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: adding allowed version rules to Renovate for packages that caused CI failures.
Description check Passed The description directly explains the Renovate rules, the affected Android and npm packages, and their relationship to the CI failures in PR #746.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@lmilbaum
lmilbaum force-pushed the fix/pr-746-audit-fixes branch from 0753bf9 to cbb62c9 Compare November 1, 2026 11:46
@lmilbaum
lmilbaum marked this pull request as ready for review November 1, 2026 11:47
@lmilbaum
lmilbaum force-pushed the fix/pr-746-audit-fixes branch from cbb62c9 to 1130724 Compare November 1, 2026 11:48
@lmilbaum lmilbaum changed the title fix(deps): address CI failures in grouped dependency update fix(renovate): add allowedVersions rules for packages that broke CI in #746 Nov 1, 2026
@lmilbaum
lmilbaum requested a review from ericcurtin November 1, 2026 11:50
@ericcurtin
ericcurtin requested a balanced review from Copilot November 1, 2026 20:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The Kotlin cap does not match the plugin dependency, and the Gradle cap leaves CI’s Java 25 update unrestricted, creating an unsupported Java/Gradle combination.

2 open issues
What changed in this PR

Adds Renovate version limits intended to prevent incompatible dependency updates from recurring in grouped PR #746.

Changes:

  • Caps Android build tools and AndroidX libraries pending migrations.
  • Restricts React, React Native libraries, Jest, and React types to versions compatible with Expo SDK 57.
  • Documents the compatibility constraints and conditions for removing the limits.
File Description
renovate.json Adds 11 package rules limiting Android and npm dependency updates.

Review effort: Balanced

Comment thread renovate.json Resolved
Comment thread renovate.json Resolved
lmilbaum added a commit to lmilbaum/llmman that referenced this pull request Nov 1, 2026
- Use matchDepNames instead of matchPackageNames for the Kotlin plugin
  cap so the <2.2.0 constraint actually matches (fixes HIGH finding)
- Add github-actions rule to pin java-jdk to 17 while Gradle wrapper
  is capped at 8.x (Gradle 8 cannot run JDK 25; fixes MEDIUM finding)

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
@lmilbaum
lmilbaum force-pushed the fix/pr-746-audit-fixes branch from 1130724 to 8f7e0f8 Compare November 1, 2026 20:45
lmilbaum added a commit to lmilbaum/llmman that referenced this pull request Nov 1, 2026
- Use matchDepNames instead of matchPackageNames for the Kotlin plugin
  cap so the <2.2.0 constraint actually matches (fixes HIGH finding)
- Add github-actions rule to pin java-jdk to 17 while Gradle wrapper
  is capped at 8.x (Gradle 8 cannot run JDK 25; fixes MEDIUM finding)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@lmilbaum
lmilbaum force-pushed the fix/pr-746-audit-fixes branch from 8f7e0f8 to 5743bc9 Compare November 1, 2026 20:47
…llmmanorg#746

Cap the Android (Gradle wrapper, Kotlin plugin, core-ktx, activity-ktx)
and npm (react, react-dom, @types/react, jest, @types/jest, webview,
keyboard-controller, screens, safe-area-context) updates that broke the
grouped update, and hold the Android CI JDK at 17 while Gradle is 8.x.
Each rule's description records why; remove it once its migration is
done.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Eric Curtin <eric.curtin@docker.com>
@ericcurtin
ericcurtin force-pushed the fix/pr-746-audit-fixes branch from 5743bc9 to 8e4aafb Compare November 1, 2026 21:06
@ericcurtin
ericcurtin merged commit 0342d0e into llmmanorg:main Nov 1, 2026
16 checks passed
@ericcurtin

Copy link
Copy Markdown
Collaborator

Thanks, merged! I amended the commit: core-ktx <1.17 and activity-ktx <1.11 match the AAR minCompileSdk, and two descriptions were fixed.

Follow-ons:

@lmilbaum
lmilbaum deleted the fix/pr-746-audit-fixes branch November 1, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants