Repository navigation
fix(renovate): add allowedVersions rules for packages that broke CI in #746 - #748
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Package version constraints renovate.json |
Gradle rules constrain the wrapper, Kotlin, core-ktx, and activity-ktx; the GitHub Actions Java JDK rule allows version 17. npm rules constrain React, React DOM, webview, keyboard-controller, screens, safe-area-context, Jest, @types/jest, and @types/react. |
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Other
Possibly related issues
llmmanorg/llmman#743lists dependency updates for packages that this PR constrains inrenovate.json.
Possibly related PRs
- llmmanorg/llmman#739: This PR extends the Renovate configuration introduced in
#739with package version rules. - llmmanorg/llmman#747: Both PRs add Renovate version constraints for dependencies associated with grouped update
#746.
Merge Risk: 
Minimal · up to 8e4aa
-
No actionable merge-blocking risk is established for these version constraints. Merge after normal configuration checks; the expected CI recovery remains unverified.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
0753bf9 to
cbb62c9
Compare
cbb62c9 to
1130724
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The Kotlin cap does not match the plugin dependency, and the Gradle cap leaves CI’s Java 25 update unrestricted, creating an unsupported Java/Gradle combination.
2 open issues
What changed in this PR
Adds Renovate version limits intended to prevent incompatible dependency updates from recurring in grouped PR #746.
Changes:
- Caps Android build tools and AndroidX libraries pending migrations.
- Restricts React, React Native libraries, Jest, and React types to versions compatible with Expo SDK 57.
- Documents the compatibility constraints and conditions for removing the limits.
| File | Description |
|---|---|
renovate.json |
Adds 11 package rules limiting Android and npm dependency updates. |
Review effort: Balanced
- Use matchDepNames instead of matchPackageNames for the Kotlin plugin cap so the <2.2.0 constraint actually matches (fixes HIGH finding) - Add github-actions rule to pin java-jdk to 17 while Gradle wrapper is capped at 8.x (Gradle 8 cannot run JDK 25; fixes MEDIUM finding) Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
1130724 to
8f7e0f8
Compare
- Use matchDepNames instead of matchPackageNames for the Kotlin plugin cap so the <2.2.0 constraint actually matches (fixes HIGH finding) - Add github-actions rule to pin java-jdk to 17 while Gradle wrapper is capped at 8.x (Gradle 8 cannot run JDK 25; fixes MEDIUM finding) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
8f7e0f8 to
5743bc9
Compare
…llmmanorg#746 Cap the Android (Gradle wrapper, Kotlin plugin, core-ktx, activity-ktx) and npm (react, react-dom, @types/react, jest, @types/jest, webview, keyboard-controller, screens, safe-area-context) updates that broke the grouped update, and hold the Android CI JDK at 17 while Gradle is 8.x. Each rule's description records why; remove it once its migration is done. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Eric Curtin <eric.curtin@docker.com>
5743bc9 to
8e4aafb
Compare
|
Thanks, merged! I amended the commit: Follow-ons:
|

Summary
Adds
allowedVersionsblock rules torenovate.jsonfor every package that caused the two CI failures in the grouped dependency update (#746). Renovate will use these rules the next time it regenerates the grouped update, so only compatible versions are proposed.Android (remove each rule once the corresponding migration is done):
<9.0.0— AGP 8.x requires Gradle 8.x; Gradle 9.6+ removed an internal API AGP 8.x depends onorg.jetbrains.kotlin.android <2.2.0— Kotlin 2.2+ promoteskotlinOptions {}to a compile error (~37 call sites)androidx.core:core-ktx <=1.15.0— 1.16+ requiresminCompileSdk=37andAGP 9.1.0androidx.activity:activity-ktx <=1.9.3— 1.10+ requiresminCompileSdk=36npm (remove when Expo SDK 58 block is lifted):
react/react-dom <=19.2.3— Expo SDK 57 pins react at 19.2.3; bumping breaksjest-expo 57react-test-renderer peerreact-native-webview <14.0.0— 14.x introduces TypeScript errors incomponents/terminal/Terminal.tsxreact-native-keyboard-controller <=1.21.9— Expo SDK 57bundledNativeModulespinreact-native-screens ~4.26.0— Expo SDK 57bundledNativeModulespinreact-native-safe-area-context ~5.7.0— Expo SDK 57bundledNativeModulespinjest/@types/jest <30.0.0—jest-expo 57depends on jest 29 internals@types/react ~19.2.0— must match the react 19.2.3 pin aboveRelationship to #746
PR #746 (
renovate/all) remains open. Once this PR is merged, triggering a Renovate rebase on #746 (or closing and reopening it) will regenerate the dependency lockfiles with all the new caps applied, which should clear both CI failures.🤖 Generated with Claude Code