fix(postgresql-proxy): prevent SSL COPY stalls by draining pending SSL buffer#12
Merged
Merged
Conversation
…g reads Co-authored-by: GitHub Copilot <copilot@github.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
cloutierMat
approved these changes
May 12, 2026
Member
cloutierMat
left a comment
There was a problem hiding this comment.
Thanks @nik-localstack for the working on that fix and reducing the PR size. I will get to reviewing the stacked PR soon. In the meantime this is GTG. Let's push and publish! 🤘
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes
UNC-472: Postgres proxy could hang forsslmode=requiresessions running largepsql -f/ COPY-heavy workloads.Root cause
selector.select()operates at the TCP layer and is unaware of data already decrypted and buffered inside the SSL layer. After an initialrecv(), buffered SSL bytes would not be seen by the nextselect()call, stalling large transfers.Changes (
postgresql_proxy/proxy.py)recv()inservice_connection(), drain any remaining SSL-buffered bytes usingsock.pending()(per Python SSL non-blocking docs).setblocking(True)on accepted sockets before SSL negotiation. On macOS/BSD, accepted sockets inheritO_NONBLOCKfrom the listening socket (unlike Linux), causing intermittentBlockingIOErroron theMSG_PEEKrecv ~1/10 times during SSL startup.Expected impact
Prevents SSL COPY-session stalls for large dump-like workloads without changing the proxy's overall non-blocking architecture.