Repository navigation
story: Wrap long questionnaire summaries inside their section - #3776
Merged
madcodelife merged 1 commit intoNov 3, 2026
Merged
Conversation
The Questionnaire story laid out its answer, navigation, event-log, and keyboard-instruction lines at their intrinsic width inside a fixed-width section. Long debug output, especially the Answers summary, overflowed the GroupBox and was clipped on both sides in the 748px documentation embed. Constrain those lines to the section width and keep them centered. Replace the fixed section widths with maximums so the sections also shrink with narrower windows instead of forcing their content past the card. Verified by building story-web and rendering ?story=Questionnaire at 748px and 480px viewports.
madcodelife
approved these changes
Nov 3, 2026
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Long debug summaries in the Questionnaire story overflowed their GroupBox and were clipped on both sides in the 748px documentation embed (
?story=Questionnaire), as reported in #2997.The answer/navigation/status lines, event logs, keyboard instructions, and focus line were laid out at their intrinsic width inside a fixed-width section. GPUI centered the overflow and the GroupBox's
overflow_x_hiddencut off both ends.w_full+text_center) so they wrap inside the card..w(px(448.))/.w(px(600.))section widths with.max_w(...), matching the StatusBar fix in website: Fit StatusBar demo sections to narrow windows #3301, so the sections also shrink with narrower windows instead of pushing content past the card.Verification
Built
crates/story-weblocally and rendered?story=Questionnaireat 748×900 (documentation embed width) and 480×900 (minimum gallery window width).cargo fmt --all -- --checkandcargo clippy -p gpui-component-story-web --no-deps --target wasm32-unknown-unknown -- --deny warningspass.No public API changes.
Part of #2997.