feat(umap): album pulldown in semantic-map titlebar#287
Merged
Conversation
Convert the album-name label in the UMAP/semantic-map floating window titlebar into a native <select> that switches albums via the same switchAlbum() path as the settings dialog dropdown, so users don't have to open Settings just to change albums. The settings album menu is unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Removed the closeSettingsModal() call from the album-selector change handler so changing albums via the pulldown no longer dismisses the settings dialog. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<select>so users can switch albums directly from there instead of opening Settings.switchAlbum()path (spinner, exit search mode, swiper rebuild,albumChangedevent), so it behaves identically to the settings dropdown.Implementation notes
umap-floating-window.html—<span id="semanticMapTitle">→<select id="semanticMapAlbumSelect">.umap.js— replacedsetSemanticMapTitle()withpopulateSemanticMapAlbumSelect()and a one-timesetupSemanticMapAlbumSelect()that wires thechangelistener and stopsmousedown/touchstart/click/dblclickpropagation on the select so the titlebar's drag and double-click-to-shade handlers don't fight the native dropdown. Removed the now-unusedgetCachedAlbumhelper.umap-floating-window.css— styled#semanticMapAlbumSelectto blend into the titlebar with a custom caret and hover/focus state.Test plan
npm run lintcleannpm run format:checkcleanruff check photomap testscleannpm test— 320/320 passingpytest tests/backend— 322 passing; the only failure is the pre-existing Python 3.14test_delete_imageissue, unrelated to this branch🤖 Generated with Claude Code