Skip to content

feat(umap): album pulldown in semantic-map titlebar#287

Merged
lstein merged 4 commits into
masterfrom
lstein/feature/umap-album-pulldown
May 26, 2026
Merged

feat(umap): album pulldown in semantic-map titlebar#287
lstein merged 4 commits into
masterfrom
lstein/feature/umap-album-pulldown

Conversation

@lstein
Copy link
Copy Markdown
Owner

@lstein lstein commented May 25, 2026

Summary

  • Convert the album-name label at the top of the UMAP/semantic-map floating window into a native <select> so users can switch albums directly from there instead of opening Settings.
  • Switching goes through the existing switchAlbum() path (spinner, exit search mode, swiper rebuild, albumChanged event), so it behaves identically to the settings dropdown.
  • Settings dialog album menu is untouched, as requested.

Implementation notes

  • umap-floating-window.html<span id="semanticMapTitle"><select id="semanticMapAlbumSelect">.
  • umap.js — replaced setSemanticMapTitle() with populateSemanticMapAlbumSelect() and a one-time setupSemanticMapAlbumSelect() that wires the change listener and stops mousedown / touchstart / click / dblclick propagation on the select so the titlebar's drag and double-click-to-shade handlers don't fight the native dropdown. Removed the now-unused getCachedAlbum helper.
  • umap-floating-window.css — styled #semanticMapAlbumSelect to blend into the titlebar with a custom caret and hover/focus state.

Test plan

  • npm run lint clean
  • npm run format:check clean
  • ruff check photomap tests clean
  • npm test — 320/320 passing
  • pytest tests/backend — 322 passing; the only failure is the pre-existing Python 3.14 test_delete_image issue, unrelated to this branch
  • Manual verification by author: switching albums from the dropdown works as advertised

🤖 Generated with Claude Code

lstein and others added 4 commits May 25, 2026 18:05
Convert the album-name label in the UMAP/semantic-map floating window
titlebar into a native <select> that switches albums via the same
switchAlbum() path as the settings dialog dropdown, so users don't have
to open Settings just to change albums. The settings album menu is
unchanged.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Removed the closeSettingsModal() call from the album-selector change
handler so changing albums via the pulldown no longer dismisses the
settings dialog.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@lstein lstein merged commit 46f1cb6 into master May 26, 2026
6 checks passed
@lstein lstein deleted the lstein/feature/umap-album-pulldown branch May 26, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant