fix(umap): keep close button visible at small/medium window sizes#290
Merged
Conversation
Bump UMAP_SIZES.small (360→440) and .medium (440→520) plot widths and tighten the titlebar icon group gap from 8px to 3px so the close (×) button is no longer clipped by the window's overflow:hidden when the floating semantic-map window is at small or medium size. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
overflow: hiddenright edge, clipping the close (×) button.UMAP_SIZES.small360→440 and.medium440→520 (plot widths; window widths are plot+60).gapfrom 8px to 3px, freeing ~30px across the 6 inter-button gaps.getCurrentWindowSize()still order correctly: small_window=500 < medium_threshold=520 ≤ medium_window=580 < big_threshold=800 ≤ big_window=860.Test plan
npm test(already verified locally: 339/339 passing).🤖 Generated with Claude Code