Skip to content

fix(umap): keep close button visible at small/medium window sizes#290

Merged
lstein merged 1 commit into
masterfrom
lstein/fix/umap-window-width
May 27, 2026
Merged

fix(umap): keep close button visible at small/medium window sizes#290
lstein merged 1 commit into
masterfrom
lstein/fix/umap-window-width

Conversation

@lstein
Copy link
Copy Markdown
Owner

@lstein lstein commented May 27, 2026

Summary

  • At small (420px) and medium (500px) sizes the semantic-map titlebar buttons (~340px total) plus the album select (max-width 60%) overflowed the window's overflow: hidden right edge, clipping the close (×) button.
  • Widen UMAP_SIZES.small 360→440 and .medium 440→520 (plot widths; window widths are plot+60).
  • Tighten the titlebar icon-group flex gap from 8px to 3px, freeing ~30px across the 6 inter-button gaps.
  • Size-detection thresholds in getCurrentWindowSize() still order correctly: small_window=500 < medium_threshold=520 ≤ medium_window=580 < big_threshold=800 ≤ big_window=860.

Test plan

  • Open the semantic map and click the Small size icon — confirm the × close button is fully visible to the right of the controls icon.
  • Click the Medium size icon — confirm the × close button is fully visible.
  • Click Large and Fullscreen — confirm no regression (sizes/layout unchanged).
  • Toggle shade (double-click titlebar) and restore — confirm the restored size is the previous unshaded size.
  • Switch between albums via the titlebar dropdown with a long album name — confirm the close button still shows at small/medium.
  • npm test (already verified locally: 339/339 passing).

🤖 Generated with Claude Code

Bump UMAP_SIZES.small (360→440) and .medium (440→520) plot widths and
tighten the titlebar icon group gap from 8px to 3px so the close (×)
button is no longer clipped by the window's overflow:hidden when the
floating semantic-map window is at small or medium size.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@lstein lstein enabled auto-merge (squash) May 27, 2026 00:58
@lstein lstein merged commit 2df2d82 into master May 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant