Repository navigation
Conversation
The test now records that the scheduled callback signaled the condition while holding the lock and checks that flag after the wait returns. It accepts elapsed times of at least 950 ms and less than 4500 ms, allowing scheduling delays while keeping completion below the configured 5000 ms timeout. Refs lysine-dev#1509
Collaborator
|
LLM code and PR/issue descriptions are forbidden per the contribution policy. This is your only warning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The test can fail when a signal arrives late, even though the wait returns before its timeout.
AwaitSignalTest.signaled checked elapsed time against a narrow expectation of 1000 ms. Scheduling the signal after 1000 ms does not guarantee it will execute that promptly.
What changed
The test now records that the scheduled callback signaled the condition while holding the lock and checks that flag after the wait returns. It accepts elapsed times of at least 950 ms and less than 4500 ms, allowing scheduling delays while keeping completion below the configured 5000 ms timeout.
Testing
The compilation check
./gradlew --no-daemon :okio:testClassestimed out after 300 seconds; no test execution was shown.Fixes #1509