WIP: hyperkit go bindings. by dlorenc · Pull Request #189 · machine-drivers/docker-machine-driver-xhyve

dlorenc · 2017-07-10T19:57:40Z

This isn't fully ready yet, but I was able to get minikube booting with it.

dlorenc · 2017-07-10T19:58:20Z

Ref #168

dlorenc · 2017-07-13T01:35:00Z

OK, @zchee this should be ready for a look. I split the vendor changes into another commit to make it easier to review.

zchee · 2017-07-13T04:33:32Z

@dlorenc Woa, I’ll check it asap.
Thanks great work!!

zchee · 2017-07-13T04:59:44Z

/cc @praveenkumar @dalehamel

praveenkumar · 2017-07-13T06:47:25Z

@dlorenc Great, I will test it out and let you know.

praveenkumar · 2017-07-13T06:52:08Z

 - package: github.com/jceel/lib9p
  version: 7be3e0b914fbb2d2ecfe2984d02bacfd8e762eae
+- package: github.com/zchee/go-vmnet
+- package: github.com/moby/hyperkit


We should put version v0.20170425 so that each iteration shouldn't get from master.

- package: github.com/moby/hyperkit version: v0.20170425

I actually need 62fb993cc65090d3efe29e9b1ed871b017eeaa4d, it contains a PR I submitted yesterday to add support for qcow and sparsebundle disks. What's the best way to pin to that in glide?

@dlorenc Then you just put this hash as version. Below should work.

- package: github.com/moby/hyperkit version: 62fb993cc65090d3efe29e9b1ed871b017eeaa4d

Done. Thanks!

dlorenc · 2017-07-20T00:40:53Z

@zchee have you had a chance to look here?

zchee · 2017-07-20T00:43:15Z

@dlorenc Ah, sorry late.
I joined @mercari yesterday. So, little busy.
but I'll check asap.

dlorenc · 2017-07-20T00:48:09Z

I joined @mercari yesterday. So, little busy.

Congrats!

zchee · 2017-07-20T00:49:12Z

@dlorenc :D

zchee · 2017-07-25T06:24:52Z

@dlorenc I'll check today

praveenkumar · 2017-08-30T05:42:00Z

@dlorenc @zchee Is there anything we are waiting for? This PR still in WIP.
@dlorenc There is some conflict, please rebase.

praveenkumar · 2017-08-30T06:42:38Z

@dlorenc I compiled from your PR and tried to provision minishift looks like networking doesn't go well and VM not able to get the IP. Another thing I noticed that now process id associate to hyperkit.

(minishift) DBG | Not there yet 60/60, error: IP not found for MAC 2:51:8:22:87:a6 in DHCP leases
- FAIL E0830 12:02:04.074449    1724 start.go:344] Error starting the VM: Error creating the VM. Error creating machine: Error in driver during machine creation: Machine didn't return an IP after 120 seconds, aborting. Retrying.
Found binary path at /usr/local/bin/docker-machine-driver-xhyve
Launching plugin server for driver xhyve
Plugin server listening at address 127.0.0.1:49376
() Calling .GetVersion
Using API Version  1
() Calling .SetConfigRaw
() Calling .GetMachineName
(minishift) Calling .GetState
FAIL E0830 12:02:04.104117    1724 start.go:344] Error starting the VM: Error getting the state for host: Unable to find 'xhyve' process by PID: 1781. Retrying.
Found binary path at /usr/local/bin/docker-machine-driver-xhyve
Launching plugin server for driver xhyve
\ Plugin server listening at address 127.0.0.1:49380
() Calling .GetVersion
Using API Version  1
() Calling .SetConfigRaw
() Calling .GetMachineName
(minishift) Calling .GetState
FAIL E0830 12:02:04.125552    1724 start.go:344] Error starting the VM: Error getting the state for host: Unable to find 'xhyve' process by PID: 1781. Retrying.
Error starting the VM: Error creating the VM. Error creating machine: Error in driver during machine creation: Machine didn't return an IP after 120 seconds, aborting
Error getting the state for host: Unable to find 'xhyve' process by PID: 1781
Error getting the state for host: Unable to find 'xhyve' process by PID: 1781

✘-INT ~/work/github/go_practice/bin 
12:02 $ ps aux | grep xhyve
prkumar          1844   0.0  0.0  2432804   1892 s002  S+   12:02PM   0:00.00 grep xhyve

✔ ~/work/github/go_practice/bin 
12:02 $ ps aux | grep hyperkit
root             1781   0.1  0.1 10855132  10612 s002  S    12:00PM   0:00.39 /Applications/Docker.app/Contents/MacOS/com.docker.hyperkit -A -u -F /Users/prkumar/.minishift/machines/minishift/hyperkit.pid -c 2 -m 8192M -s 0:0,hostbridge -s 31,lpc -s 1:0,virtio-vpnkit,path=/Users/prkumar/Library/Containers/com.docker.docker/Data/s50 -s 2:0,virtio-net -U F4BB3F79-AB4E-4708-95CA-E32FBFCDEFD3 -s 3:0,ahci-hd,/dev/rdisk2 -s 4,virtio-rnd -l com1,autopty=/Users/prkumar/.minishift/machines/minishift/tty,log=/Users/prkumar/.minishift/machines/minishift/console-ring -f kexec,/Users/prkumar/.minishift/machines/minishift/vmlinuz64,/Users/prkumar/.minishift/machines/minishift/initrd.img,earlyprintk=serial loglevel=3 user=docker console=ttyS0 console=tty0 noembed nomodeset norestore waitusb=10:LABEL=boot2docker-data base
prkumar          1857   0.0  0.0  2432804   1900 s002  S+   12:02PM   0:00.00 grep hyperkit

praveenkumar · 2017-09-08T08:59:20Z

@dlorenc @zchee ping !

zchee · 2017-09-14T15:35:39Z

@praveenkumar Ah, sorry. I"ll reply tomorrow.

periklis · 2017-11-22T16:19:46Z

@dlorenc & @zchee can some of you elaborate if this changeset removes the need to use sudo?

dlorenc mentioned this pull request Jul 10, 2017

HyperKit Driver kubernetes/minikube#1543

Closed

dlorenc force-pushed the hyperkit branch 3 times, most recently from b9b9a88 to 0a32047 Compare July 13, 2017 01:34

dlorenc added 2 commits July 12, 2017 18:36

Switch to the official go hyperkit bindings.

0a11b82

Vendor changes.

3acd3bc

dlorenc force-pushed the hyperkit branch from 0a32047 to 3acd3bc Compare July 13, 2017 01:37

praveenkumar reviewed Jul 13, 2017

View reviewed changes

This was referenced Jul 13, 2017

Multiple NFS shares #121

Merged

Switch from using hdiutil to parsing the iso file directly. #183

Open

Makefile cleanup.

45b19f5

dlorenc force-pushed the hyperkit branch from 6e20deb to 45b19f5 Compare July 17, 2017 20:50

praveenkumar mentioned this pull request Aug 30, 2017

Using Hyperkit as a driver on macOS minishift/minishift#1326

Closed

periklis mentioned this pull request Oct 25, 2018

Is virtualisation.docker.enable possible for macOS? nix-darwin/nix-darwin#112

Closed

Conversation

dlorenc commented Jul 10, 2017

Uh oh!

dlorenc commented Jul 10, 2017

Uh oh!

dlorenc commented Jul 13, 2017

Uh oh!

zchee commented Jul 13, 2017

Uh oh!

zchee commented Jul 13, 2017

Uh oh!

praveenkumar commented Jul 13, 2017

Uh oh!

praveenkumar Jul 13, 2017

Choose a reason for hiding this comment

Uh oh!

zchee Jul 13, 2017

Choose a reason for hiding this comment

Uh oh!

dlorenc Jul 13, 2017

Choose a reason for hiding this comment

Uh oh!

praveenkumar Jul 13, 2017

Choose a reason for hiding this comment

Uh oh!

dlorenc Jul 17, 2017

Choose a reason for hiding this comment

Uh oh!

dlorenc commented Jul 20, 2017

Uh oh!

zchee commented Jul 20, 2017

Uh oh!

dlorenc commented Jul 20, 2017

Uh oh!

zchee commented Jul 20, 2017

Uh oh!

zchee commented Jul 25, 2017

Uh oh!

praveenkumar commented Aug 30, 2017

Uh oh!

praveenkumar commented Aug 30, 2017

Uh oh!

praveenkumar commented Sep 8, 2017

Uh oh!

zchee commented Sep 14, 2017

Uh oh!

periklis commented Nov 22, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants