[makspll]

Stacked on #668.

The asset functions of world are typed by the asset type, with the TypeOf / ValueOf wrappers of #668 and the declared Handle<A>:

fn load_asset(ctxt, path: String, asset_type: TypeOf<V<ScriptTypeRegistration>, A>) -> Result<ValueOf<Handle<A>>, InteropError>
fn get_asset(ctxt, handle: ValueOf<Handle<A>>, registration: TypeOf<V<ScriptTypeRegistration>, A>) -> Result<Option<ValueOf<A>>, InteropError>
fn add_asset(ctxt, value: ValueOf<A>) -> Result<ValueOf<Handle<A>>, InteropError>
// has_asset, is_loaded, load_state, asset_path take a `ValueOf<Handle<A>>`

In the LAD file the handle is Handle applied to the parameter, { "val": { "generic_type": "bevy_asset::handle::Handle", "args": [{ "val": { "param": "A" } }] } }, and isn't recorded as an instantiation of Handle.

Lua

---@generic A
---@param path string
---@param asset_type A
---@overload fun(path: string, asset_type: bms.ScriptTypeRegistration): ReflectReference
---@return asset.Handle<A>
function World.load_asset(path, asset_type) end

Generic functions now get the untyped overload whenever an argument uses a parameter, not only for type arguments, so an untyped handle (a ReflectReference) can still be passed to is_loaded. Values of a type applied to a parameter, like Handle<A>, are references in the overload.

Checked with LuaLS 3.19.2:

Expression	Inferred
world.load_asset("image.png", Image)	asset.Handle<render.Image>
world.get_asset(handle, Image)	render.Image?
world.add_asset(image) (image: render.Image)	ReflectReference | asset.Handle<render.Image> (merged with the overload)
world.is_loaded(untyped) (untyped: ReflectReference)	boolean

The typed Image.load(path) / Image.get_asset(handle) of each asset type were already typed and are unchanged.

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
crates/lad_backends/lua_language_server_lad_backend/src/convert.rs	70% smaller
crates/ladfile_builder/src/plugin.rs	48% smaller
crates/lad_backends/lua_language_server_lad_backend/src/convert/generics.rs	9% smaller
crates/bindings/bevy_mod_scripting_bevy_asset_bindings/src/lib.rs	1% smaller
crates/bevy_mod_scripting_functions/src/core.rs	0% smaller
docs/src/ReleaseNotes/0.23-to-0.24.md	Unsupported file format