Improve ConnectionManager to handle trailing slash (/) in base_url automatically #707
Open
DanielYang59 wants to merge 2 commits intomarcospereirampj:masterfrom
Open
Improve ConnectionManager to handle trailing slash (/) in base_url automatically #707DanielYang59 wants to merge 2 commits intomarcospereirampj:masterfrom
/) in base_url automatically #707DanielYang59 wants to merge 2 commits intomarcospereirampj:masterfrom
Conversation
DanielYang59
changed the title
base_url to handle trailing slash automatically base_url to handle trailing slash (/) automatically
DanielYang59
force-pushed
the
handle-server-url
branch
4 times, most recently
from
c6efc5c to
1ba1daa
Compare
DanielYang59
changed the title
base_url to handle trailing slash (/) automatically /) in base_url automatically
DanielYang59
force-pushed
the
handle-server-url
branch
from
aff5376 to
1952d76
Compare
DanielYang59
requested review from
marcospereirampj and
ryshoooo
as code owners
Author
|
@ryshoooo can you please review this? Here I didn't normalize |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #149