Repository navigation
fix: import Apple where specs use @Apple - #1990
Merged
Merged
Conversation
#1970 switched the packed consumer check's spec and the `HybridObject` example to `@Apple`, but both still imported `iOS`. The consumer check's spec then failed to typecheck ("Cannot find name 'Apple'").
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "build" check has failed on
v1PRs since #1970. The spec thatcheck-consumerwrites uses@Applebut importsiOS, so it fails to typecheck withCannot find name 'Apple'. It now importsApple. TheHybridObjectJSDoc example had the same mismatch.I ran the CI steps locally (
npm packfor the three packages, thenbun check-consumer), and both consumer checks pass.🤖 Generated with Claude Code