Repository navigation
fix(android): Only unbind this CameraSession's use cases instead of unbindAll() - #4229
Open
OlimpiaZurek wants to merge 1 commit into
Open
OlimpiaZurek wants to merge 1 commit into
OlimpiaZurek wants to merge 1 commit into
Conversation
|
@OlimpiaZurek is attempting to deploy a commit to the Margelo Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Oct 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes an Android
CameraSessionunbind only the use cases it bound, instead of callingcameraProvider.unbindAll(). Opening one camera no longer turns off another camera that is still mounted.Problem
HybridCameraSessioncallscameraProvider.unbindAll()inconfigure()anddispose().ProcessCameraProvideris shared across the app, so the call also unbinds every other mounted<Camera>.We hit this when a camera screen stays mounted with
isActive={false}while another camera screen is pushed on top:<Camera>and navigates to screen B, which has its own<Camera>. A stays mounted and goes inactive.unbindAll()when it configures and again when it disposes. Both calls unbind A's use cases.isActivebecomes true, butstart()only activates the lifecycle. A's props haven't changed, soconfigure()doesn't run, nothing is bound, and the preview stays black until A remounts.