feat: support comments between concise mode line attributes#225
Conversation
🦋 Changeset detectedLatest commit: 6a6e515 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (4)
WalkthroughThe parser’s concise-mode open-tag handling now scans past whitespace and line or block comments after a newline before checking for a comma. If no comma is found, it exits the open-tag state. The PR also adds fixtures covering multiline comma-separated attributes with inline, block, and trailing comments, plus a changeset entry noting the new support. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 34 34
Lines 4233 4261 +28
Branches 782 792 +10
=======================================
+ Hits 4231 4259 +28
Misses 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Allow `//` and `/*...*/` comment lines between comma-prefixed line attributes in concise mode. The comments are scanned over (not emitted) and no longer terminate the open tag. Fixes #203
77ac694 to
6a6e515
Compare
Fixes #203.
A comment line between comma-prefixed concise line attributes previously terminated the open tag, so the following line was misparsed as a new tag:
The open tag now scans over
//and/*...*/comment lines between line attributes. The comments are skipped (not emitted), consistent with comments elsewhere in an open tag, and no longer end the tag. A trailing comment that isn't followed by another line attribute is still treated as content, preserving existing behavior.Includes test fixtures and a changeset.
Generated by Claude Code