Repository navigation
Restore support for 5.x branch - #31
Closed
inflatador wants to merge 1 commit into
Closed
inflatador wants to merge 1 commit into
inflatador wants to merge 1 commit into
Conversation
[This change by @sgiehl ](matomo-org#23) removed support for the Matomo 5.x branch. However, based on the comment "no code changes were needed", I guessed that the plugin would work fine on Matomo 5.x, and I can confirm it installs and works correctly on the latest 5.x release (5.14.1). Restore support for the 5.x branch so users don't have to use a beta version of Matomo to use the json array support added by matomo-org#27 Closes matomo-org#30
Member
|
@inflatador we do not want to maintain Matomo 5 support on 6.x-dev branch. If any new feature should be included in a plugin release for Matomo 5, that feature would need to be backported onto 5.x-dev branch and a new release would need to be published. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change by @sgiehl removed support for the Matomo 5.x branch.
However, based on the comment "no code changes were needed", I guessed that the plugin would work fine on Matomo 5.x, and I can confirm it installs and works correctly on the latest 5.x release (5.14.1).
Restore support for the 5.x branch so users don't have to use a beta version of Matomo to use the json array support added by #27
Closes #30
Checklist