Skip to content

Move the 5.x-dev checks onto the shared Plugins CI umbrella [ignore_release] - #355

Merged
snake14 merged 3 commits into
5.x-devfrom
plugins-ci-umbrella-5x
Oct 21, 2026
Merged

snake14 merged 3 commits into
5.x-devfrom
plugins-ci-umbrella-5x

Conversation

@snake14

@snake14 snake14 commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Description

Brings 5.x-dev onto the shared Plugins CI umbrella that 6.x-dev already uses. ci.yml is the 6.x-dev caller: it replaces the standalone AI checklist and PHPCS workflows, and adds the PHPStan, license, compatibility, timezone safety and release date checks. It also adds the canonical pre-push hook, which verify-hook: true now enforces.

5.x-dev had no phpstan.neon, so it is ported from 6.x-dev with phpVersion lowered to 7.2, the minimum PHP Matomo 5 supports.

PHPStan analyses this plugin at PHP 7.2, so this branch carries #354's parse fix for Queue/Backend/RedisCluster.php and ports 6.x-dev's PHPStan fixes. The changes it shares with #354 are identical, so either can merge first, but #354 still needs to merge: it carries the version bump, changelog entries and regression test.

Issue No

No GitHub issue.

Steps to Replicate the Issue

NA

Checklist

  • [✔] Tested locally or on demo2/demo3?
  • [NA] New test case added/updated?
  • [NA] Are all newly added texts included via translation?
  • [NA] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
  • [NA] Version bumped?
  • [✔] I have understood, reviewed, and tested all AI outputs before use
  • [✔] All AI instructions respect security, IP, and privacy rules
  • [NA] Documentation updated?

…e_release]

Suppresses the remaining findings where the ext-redis stubs or Matomo 5.0's docblocks are narrower than the code's real contract.
@snake14
snake14 requested a review from a team October 20, 2026 22:08
@snake14
snake14 enabled auto-merge (squash) October 20, 2026 22:08
@snake14
snake14 merged commit 7defed1 into 5.x-dev Oct 21, 2026
26 of 38 checks passed
@snake14
snake14 deleted the plugins-ci-umbrella-5x branch October 21, 2026 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants