Repository navigation
Conversation
A tracking step can catch an error after which the database already rolled back the transaction; the set now goes down the retry path, and a failed run rolls back before releasing its lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEV-20866
Follow-up to matomo-org/matomo#25549, which makes the tracker connection refuse every query and the commit after an error that rolled back the transaction.
If a tracking step caught such an error on the last query of a request set, nothing noticed until the lock or commit queries, which then failed outside the retry path. The worker crashed, and the unlock in the error handler failed too, so the lock stayed held until it expired.
TransactionErrorswhen it exists.Both checks are skipped on Matomo versions without the core change. The new
HandlerTestcase needs the core PR, and is skipped without it.Review