Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/weekly-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@ name: Weekly release
on:
# Run by hand for now; the Monday schedule and the other-branches sweep come later.
workflow_dispatch:
inputs:
skip-ci-check:
description: "Release this branch even though its CI failed or is still running"
type: boolean
default: false

permissions: {}

Expand All @@ -12,3 +17,8 @@ jobs:
contents: write
pull-requests: write
uses: matomo-org/plugin-ci-workflows/.github/workflows/plugin-dev-release.yml@main
with:
skip-ci-check: ${{ inputs.skip-ci-check || false }}
secrets:
# A user other than github-actions, so the bot's date PR can be approved and merged.
approver-token: ${{ secrets.TESTS_ACCESS_TOKEN }}
32 changes: 32 additions & 0 deletions phpstan-min-matomo.neon
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
includes:
- phpstan.neon

parameters:
tmpDir: /tmp/phpstan/QueuedTracking/min
ignoreErrors:
# The ext-redis stubs bundled with the PHPStan of the minimum-supported Matomo disagree with
# the extension this plugin actually runs against: RedisCluster::info() is
# (array|string $key_or_address, string $sections = '') returning RedisCluster|array|false,
# flushDB() takes array|string, and config() is (key_or_address, subcommand, ...extra_args)
# with two required arguments. Every call below matches the extension, not the stub. The
# newer PHPStan on the maximum leg has corrected stubs, so there these would be unmatched.
-
identifier: arguments.count
message: '#RedisCluster::config\(\) invoked with 3 parameters#'
path: Commands/Test.php
count: 1
-
identifier: offsetAccess.notFound
message: "#Offset 'redis_version' does not exist on non-falsy-string#"
path: Queue/Backend/RedisCluster.php
count: 1
-
identifier: nullCoalesce.offset
message: "#Offset 'used_memory(_peak)?' on string on left side of \\?\\? does not exist#"
path: Queue/Backend/RedisCluster.php
count: 2
-
identifier: argument.type
message: '#RedisCluster::flushDB\(\) expects string, array#'
path: Queue/Backend/RedisCluster.php
count: 1
25 changes: 0 additions & 25 deletions phpstan.neon
Original file line number Diff line number Diff line change
Expand Up @@ -12,31 +12,6 @@ parameters:
# still resolve the client's methods while the library keeps its own conventions.
- libs/credis/*
ignoreErrors:
# The bundled ext-redis stubs disagree with the extension this plugin actually runs
# against. Reflected in the environment: RedisCluster::info() is
# (array|string $key_or_address, string $sections = '') returning RedisCluster|array|false,
# flushDB() takes array|string, and config() is (key_or_address, subcommand, ...extra_args)
# with two required arguments. Every call below matches the extension, not the stub.
-
identifier: arguments.count
message: '#RedisCluster::config\(\) invoked with 3 parameters#'
path: Commands/Test.php
count: 1
-
identifier: offsetAccess.notFound
message: "#Offset 'redis_version' does not exist on non-falsy-string#"
path: Queue/Backend/RedisCluster.php
count: 1
-
identifier: nullCoalesce.offset
message: "#Offset 'used_memory(_peak)?' on string on left side of \\?\\? does not exist#"
path: Queue/Backend/RedisCluster.php
count: 2
-
identifier: argument.type
message: '#RedisCluster::flushDB\(\) expects string, array#'
path: Queue/Backend/RedisCluster.php
count: 1
# Three backends share one $redis property and one getConnection(), holding \Redis,
# \RedisCluster or Credis_Client depending on how the queue is configured. Credis_Client
# mirrors the phpredis API deliberately, which is what makes the arrangement work at
Expand Down
Loading