Repository navigation
Conversation
lachiebol
approved these changes
Oct 1, 2026
lachiebol
left a comment
Contributor
There was a problem hiding this comment.
LGTM, works well locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Lets the new
core:rotate-encryption-keysconsole command (matomo-org/matomo#25410) replace this plugin's encryption key and re-encrypt the stored Slack OAuth token with the new key. Until now, changingencryption_keyin the[Slack]config section made those values unrecoverable.The plugin declares its encrypted values through the new
CoreAdminHome.getEncryptionKeyRotationTargetsevent, andEncryption::withKey()lets values be encrypted and decrypted with a key other than the configured one. On a Matomo version without the command, nothing changes.Depends on matomo-org/matomo#25410.
Issue No
PG-5545
Steps to Replicate the Issue
./console core:rotate-encryption-keys --plugin=Slack.encryption_keyin the[Slack]section of the config file has changed, and sending a Slack report or alert still works.Checklist