feat(ServicePatterns): use real service names#3274
Open
thecristen wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: followup to Update description for light/heavy rail friday services
Implementation
Our current logic overrides the names for typical schedules, which means we couldn't show the named "Friday and Matchday schedule". This removes the override and lets the service descriptions from the data shine through.
This might have some unexpected results across other routes so I'll put it on dev-green for folks to explore.
Screenshots
How to test
Go to the departures page for your favorite routes and observe that for typical (non-holiday/extra/disruption/etc) services the description actually matches what comes from the V3 API!