fix: suppress xlings subprocess noise on Windows during bootstrap#57
Merged
Conversation
Two places in the first-run bootstrap path were missing output
redirection on Windows, causing xlings internal messages to leak
to the terminal:
1. ensure_init(): `xlings self init` ran without any output redirect
on Windows (Linux/macOS already had >/dev/null 2>&1). Now appends
platform::shell::silent_redirect (">/dev/null 2>&1" on Windows).
2. install_with_progress() fallback: the NDJSON interface command
had no stderr redirect on Windows (Linux/macOS had 2>/dev/null).
Now appends platform::null_redirect ("2>nul" on Windows).
After this fix, the first-run experience is consistent across all
three platforms — only mcpp's own status messages and progress bars
are shown; xlings internal output is fully suppressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensure_init()missing output redirect on Windows —xlings self initinternal messages no longer leak to terminalinstall_with_progress()fallback missing stderr redirect on Windows — NDJSON interface stderr suppressedProblem
Windows first-run printed excessive xlings internal output (debug messages, extraction logs) while Linux/macOS were clean and silent. Two subprocess calls were missing platform-appropriate output redirection on Windows.
Test plan