Skip to content

Harden update + nginx 1.30.7 (HTTP/2 CVE) - #184

Merged
peti12352 merged 3 commits into
devfrom
harden-update-durable
Nov 18, 2026
Merged

peti12352 merged 3 commits into
devfrom
harden-update-durable

Conversation

@peti12352

@peti12352 peti12352 commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

nginx2root (CVE-2026-123007 et al.)

  • Relevant: yes. Goethe ships nginx and enables HTTP/2 on gateway + share listeners.
  • Pinned 1.30.6 → 1.30.7 (stable fix line); goethe doctor warns on older builds.
  • Attack realism: anyone who can reach the listen address (public expose/share, or same VPN/tailnet) could attempt RCE as the nginx worker (usually the Goethe user, not root). Host root needs a separate kernel/SCTP issue (OS-level). Localhost-only bind is much lower risk.
  • Action for operators: rebuild/republish the package; then goethe update refreshes the binary.

Update gaps (provoked, then fixed)

Gap Proof Fix
Post-bin engine refresh parse(["update","--engine"]) errs; code re-exec'd that Re-exec update engine --yes
nginx not on update setup staged nginx; update did not Stage/swap nginx when signed sha differs; reload if running
Pack vs pin/installed skew offers with pin 9.x while installed 0.0.1 pack_engine_version / runnable_at / offers_for use installed wheel when present
VERSION after engine VERSION wrote even if engine re-exec failed Write VERSION only when engine refresh succeeded (or not needed)
Docs drift CHANGELOG said --rollback / --engine Positional engine | rollback; cli note on future clap-driven tables

Default UX: plain goethe update still one command; it now also refreshes installed engines and nginx when due.

Ponytail cuts

  • CI: clippy folded into engine-test; fresh-user+user-paths → e2e-user
  • Dedup: shared nginx::persist_named_limits / nginx::quote
  • YAGNI: drop TokenSource/Login; Broker as &impl
  • stdlib: normalize_arch via std::env::consts::ARCH
  • Delete dead ninfer::sha256_file public wrapper + obsolete e2e findings doc
  • Skipped false dupes: write_private, flock helpers (different semantics)

Greengoblin E2E (isolated home, PR binary a17b1c9)

  • Pack embed: install → load → run (dims=768) → unload ✓
  • Chat: local qwen3-vl-8b via llama.cpp load → run → unload ✓
  • Fail-closed: expose public --yes and share without --allow refuse ✓
  • Doctor warns system nginx 1.24.0 below 1.30.7 floor; update --check offers nginx fetch ✓
  • Note: update --yes against current CDN swaps to published 677efb4 (older than this PR build) — use --check when validating a local newer build
  • SGLang: Qwen3.8-27B-NVFP4 installs/selects sglang but does not fit 5090 (weights 30.8 GB); boot __main__ guard present in tree + unit tests (colleague fix already on dev)
  • Prod restored: tailnet+localhost 8443 only, no 8444

Test plan

  • cargo test -p goethe-core --lib (touched modules)
  • pack engine_too_old / offers_for skew asserts
  • lint_style clean
  • CI gate on this PR
  • Greengoblin real-user E2E (isolated home)
  • Rebuild CDN nginx binary from new pin (release ops)

Made with Cursor

… builds.

Goethe enables HTTP/2 on the gateway and share listeners; 1.30.6 is in the
affected range for CVE-2026-123007. Package rebuild still required to ship the binary.
… the installed wheel.

Prove-and-fix: re-exec used invalid --engine (clap wants positional engine);
plain update skipped bundled nginx; packs gated on compile-time PIN so a new
binary with an old py-env could accept packs it cannot run. Docs match the CLI.
Fold clippy into engine-test and merge FreshUser+Matrix e2e; unify nginx limit/quote helpers; simplify pack broker auth; use std ARCH.
@peti12352
peti12352 merged commit 5a99951 into dev Nov 18, 2026
13 checks passed
@peti12352
peti12352 deleted the harden-update-durable branch November 19, 2026 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant