Skip to content

Module splits for install, menu, and supervisor - #190

Open
peti12352 wants to merge 9 commits into
devfrom
maintainability-project-md
Open

peti12352 wants to merge 9 commits into
devfrom
maintainability-project-md

Conversation

@peti12352

@peti12352 peti12352 commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Extract helpers into install_gguf, install_pack_fit, install_offer, menu_draw, supervisor_load, and supervisor_lifecycle, re-exported from the original modules
  • Add goethe/tests/equiv_split_gate.sh for split checks (LOC soft max, clippy, lint_style, lib test pass count and names, dependents)
  • Public APIs stay on the original module paths; no intentional behavior changes

Test plan

  • bash goethe/tests/equiv_split_gate.sh check on all new modules (647 lib tests)
  • cargo clippy -p goethe-core --locked --all-targets -- -D warnings
  • python3 goethe/tests/lint_style.py
  • CI: lint, engine-test, e2e-user, gate

First bite of the install god file: before-download SGLang vs llama.cpp choice stays pure of card/HF install I/O.
Records goethe-core lib pass counts and bare test names, then re-checks compile, clippy, lint, dependents, and LOC on new modules.
Write full test and --list output to files so pipefail cannot drop the baseline.
Move Marlin sizing, PackWeights, pack_input, and pack_fit out of install; nested module keeps InstallOpts access without API churn.
Move structure_offer, offer_for, pack_decision, and ask_login out of install; download confirm stays with hub I/O.
@peti12352 peti12352 changed the title Zero-divergence module splits for install, menu, and supervisor Module splits for install, menu, and supervisor Nov 19, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant