Repository navigation
Conversation
First bite of the install god file: before-download SGLang vs llama.cpp choice stays pure of card/HF install I/O.
Records goethe-core lib pass counts and bare test names, then re-checks compile, clippy, lint, dependents, and LOC on new modules.
Write full test and --list output to files so pipefail cannot drop the baseline.
Move Marlin sizing, PackWeights, pack_input, and pack_fit out of install; nested module keeps InstallOpts access without API churn.
Move structure_offer, offer_for, pack_decision, and ask_login out of install; download confirm stays with hub I/O.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install_gguf,install_pack_fit,install_offer,menu_draw,supervisor_load, andsupervisor_lifecycle, re-exported from the original modulesgoethe/tests/equiv_split_gate.shfor split checks (LOC soft max, clippy, lint_style, lib test pass count and names, dependents)Test plan
bash goethe/tests/equiv_split_gate.sh checkon all new modules (647 lib tests)cargo clippy -p goethe-core --locked --all-targets -- -D warningspython3 goethe/tests/lint_style.py