Repository navigation
Add AllowImportantInStyles policy option to optionally retain !important declarations - #229
Open
AdamMagued wants to merge 1 commit into
Open
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
Add Policy.AllowImportantInStyles(bool) to permit !important declarations in style attributes when explicitly opted in, while preserving the default behavior of stripping !important for security.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
Policy.AllowImportantInStyles(allow bool) *Policyto allow retaining!importantannotations on allowed inline CSS styles when explicitly opted in.Technical Context & Root Cause
When parsing style declarations,
github.com/aymerick/douceur/parserstrips!importantfrom the declaration value and stores it in theDeclaration.Importantboolean field. During sanitization insanitizeStyles, Bluemonday rebuilt declarations solely asdec.Property + ": " + dec.Value, omitting!important.For security reasons, stripping
!importantremains the default behavior (allowImportantInStyles = false). When opted in viap.AllowImportantInStyles(true), any allowed declaration withdec.Important == truepreserves!importantin the sanitized output.Verification
TestAllowImportantInStylescovering default stripping, opt-in retention, mixed declarations, global and element-scoped styles, invalid property stripping, and disabling after enabling.TestIssue221covering issue Feature request: Optional support for !important #221 examples and concurrent execution under the race detector.go test -race -v ./...; all tests pass.Fixes #221