Repository navigation
fix: treat mailto: links as fully qualified for target/rel options - #232
Open
TastyHeadphones wants to merge 1 commit into
Open
TastyHeadphones wants to merge 1 commit into
TastyHeadphones wants to merge 1 commit into
Conversation
Go parses mailto URLs as opaque (Host empty), so AddTargetBlank / RequireNoFollow / RequireNoReferrer on fully-qualified links skipped them (microcosm-cc#231). Count mailto with a non-empty opaque part as external. Disclosure: drafted with Grok assistance; I reviewed and tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #231.
AddTargetBlankToFullyQualifiedLinks,RequireNoFollowOnFullyQualifiedLinks, andRequireNoReferrerOnFullyQualifiedLinksonly treated a link as fully qualified whenurl.Parse(href).Host != "". Go parsesmailto:URLs as opaque (Host == ""), so those options never applied to mailto links (webmail clients then navigate the current tab away).Treat
mailto:with a non-empty opaque part as fully qualified as well.Test plan
TestMailtoFullyQualifiedLinksgo test -count=1 -run TestMailtoFullyQualifiedLinks .AI disclosure
Drafted with Grok assistance; I reviewed the change against #231 and ran the new regression test.