pathlib: Fix glob() to return Path objects rather than strings.#1027
pathlib: Fix glob() to return Path objects rather than strings.#1027RotatingLlama wants to merge 3 commits intomicropython:masterfrom
Conversation
|
This discrepancy with cpython caught me out recently too, thanks for submitting the fix. Would you be able to update the commit message to match the repo standard needs patterns and force-push to the same branch? That would fix the ci failure. |
|
No probs, it's very minor. This is actually my first pull request and I spent about half an hour yesterday trying to fix the error, but couldn't figure out how to do it. Would you give me a pointer, please? |
Fix glob() to return Path objects rather than bare strings, same as CPython https://docs.python.org/3/library/pathlib.html#pathlib.Path.glob
Fix glob() to return Path objects rather than bare strings, same as CPython https://docs.python.org/3/library/pathlib.html#pathlib.Path.glob
|
I've now spent literal hours of my life trying to understand how to fix this pull request, and am still no further forward. I'm not willing to waste any more time for the sake of such a minor correction. I'm going to see if I can delete it for the sake of keeping the place tidy, but if it won't let me do that either then I'm out. |
Fix glob() to return Path objects rather than bare strings, same as CPython https://docs.python.org/3/library/pathlib.html#pathlib.Path.glob