Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands the event “severity/level” handling so additional ETW level codes are converted into user-facing strings during event resolution.
Changes:
- Add
CriticalandVerbosetoSeverityLevel. - Extend
Severity.GetString(byte? level)to map level1→Criticaland level5→Verbose. - Update resolver unit tests to assert the new level-to-string mappings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/EventLogExpert.Eventing/Helpers/SeverityMethods.cs |
Adds missing severity level names and maps additional ETW level codes to display strings. |
src/EventLogExpert.Eventing.Tests/EventResolvers/EventResolverBaseTests.cs |
Updates test cases to validate the new severity string mappings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jschick04
force-pushed
the
Updated_Severity
branch
from
39fb48e to
42262a9
Compare
jschick04
force-pushed
the
Updated_Severity
branch
from
42262a9 to
f50b2e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.