[Drop, 97 changes] Sync through 2022/11/18 17:00 - Pre-unix-gcr1#59

Open

MsftBrettShirley wants to merge 102 commits into

mainfrom

users/esedev/SyncToEFV9620Part1UnixGcr1

Commits on Sep 27, 2025

Compile with C++17

TAW
authored and
Brett Shirley (from Dev Box)
committed
Prepare to replace C_ASSERT with static_assert

TAW
authored and
Brett Shirley (from Dev Box)
committed
Added simulation of subsampling of cache traces in resmgrreplay

Nathanael Cheriere
authored and
Brett Shirley (from Dev Box)
committed
OSSBUILD: Uninit variable defense is stronger in github test code.

Brett Shirley
authored and
Brett Shirley (from Dev Box)
committed

Commits on Sep 28, 2025

Replace buggy .NET Framework event log reader with our own implementation.

Alexandre Costa
authored and
Brett Shirley (from Dev Box)
committed
Log extent freed when an allocated extent is rolled back to help reconcile page if it is within required range

Vakishan
authored and
Brett Shirley (from Dev Box)
committed
Improve detection of whether transaction is actually holding back version store cleanup. Also, trigger version store cleanup task when read-only transaction check for max transaction size

Anil Ruia
authored and
Brett Shirley (from Dev Box)
committed
Adjust loose truncation threshold for RBS and add max RBS space threshold

Vakishan
authored and
Brett Shirley (from Dev Box)
committed
Improve conflict resolution logic in Leak Report.

Alexandre Costa
authored and
Brett Shirley (from Dev Box)
committed

Commits on Oct 11, 2025

Sync Windows/ESENT changes to Exchange/ESE

Michael Thorp
authored and
Brett Shirley (from Dev Box)
committed
Adding subsampling of cache traces in ESE

Nathanael Cheriere
authored and
Brett Shirley (from Dev Box)
committed
Modify ECC correction code to detect and repair bit flips on the checksum format flag.

Umair Ahmad
authored and
Brett Shirley (from Dev Box)
committed
Change jethdr.W to wrap base types

TAW
authored and
Brett Shirley (from Dev Box)
committed
Remove bad assert in ErrCATIBuildFIELDArray(), fix bad printf format string in CPAGE::ErrCheckPage()

Alexandre Costa
authored and
Brett Shirley (from Dev Box)
committed
ESE Block Cache: add more bits to the Presence Filter

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
ESE Block Cache: try to reduce slab access overhead in RequestFinalizeRead

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
Shrink should succeed with sdrNoLowAvailSpace when it can't grow the DB, not fail with JET_errOutOfDatabaseSpace

Alexandre Costa
authored and
Brett Shirley (from Dev Box)
committed
ESE Block Cache: allow uncached file access to succeed if the underlying file does not support FileIdInfo

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
ESE Block Cache: fix Cuckoo Filter issue with standby list

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
Turn Shrink archiving off

Alexandre Costa
authored and
Brett Shirley (from Dev Box)
committed
Fix bug when pvpage is null due to some flags being set but not compress or dehydrate flags

Vakishan
authored and
Brett Shirley (from Dev Box)
committed
Add dbtime to RBS root page records and remove duplicates from being applied in a loop using dbtime to uniquely identify the record

Vakishan
authored and
Brett Shirley (from Dev Box)
committed
Add additional validation to make sure reverted table being redelete have PageFDPDelete flag set

Vakishan
authored and
Brett Shirley (from Dev Box)
committed
ESE Block Cache: fix lost write caused by incorrect update of presence filter during eviction

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
Fix RBS delete flag check failing due to the check using an int instead of a bool

Vakishan
authored and
Brett Shirley (from Dev Box)
committed
ESE Block Cache: avoid corruption if we ever access cached file offsets >= 16TB

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
ESE Block Cache: don't emit telemetry for invalid path when attaching a file to the cache

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
ESE: add optional type check to read shadowed header

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
Slight normalization of ESENT vs ESE

TAW
authored and
Brett Shirley (from Dev Box)
committed
ESE: simplify hung io detection in BF to avoid accessing invalid IO contexts

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
Some re-org of our types

TAW
authored and
Brett Shirley (from Dev Box)
committed
Hybrid Shrink Phase 0.1: remove fully-flighted configuration options.

Alexandre Costa
authored and
Brett Shirley (from Dev Box)
committed
ESE Block Cache: copy status

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed

Commits on Oct 12, 2025

ESE Block Cache: Perf: copy ctor for CCachedBlockSlot

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed

Commits on Oct 13, 2025

ESE Block Cache: Copy Status fixes

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
ESE Block Cache: Perf: flush all state on a clean dismount to prevent repeated recovery on file accesses

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
Do not crash on cache-bypass lost flushes in the test pass if it heals after one retry.

Alexandre Costa
authored and
Brett Shirley (from Dev Box)
committed
Miscellaneous test fixes

Alexandre Costa
authored and
Brett Shirley (from Dev Box)
committed
Break up the RECIRetrieveTaggedColumnsRecTooBig14.1 FireWall so we can see what the is going on.

Brett Shirley
authored and
Brett Shirley (from Dev Box)
committed
ESE Block Cache: add alloc pool for CThreadLocalStorage::CRequest (redo)

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
ESE: JetRenameColumn errata

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
Hybrid Shrink Phase 0.2: permanently enable lgposLastResize-based DB extension redo.

Alexandre Costa
authored and
Brett Shirley (from Dev Box)
committed
Hybrid Shrink Phase 0.3: improve DB Shrink optics.

Alexandre Costa
authored and
Brett Shirley (from Dev Box)
committed
ESE Block Cache: fix IFileIdentification::ErrGetFileId to ignore all unsupported scenarios

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
Use OBJID to match FCB obtained by hashing pgnoFDP during leak report

Alexandre Costa
authored and
Brett Shirley (from Dev Box)
committed
Merge LR should skip adding page for reconciliation if macro begin is outside checkpoint

Vakishan
authored and
Brett Shirley (from Dev Box)
committed
Pull strsafe.h out of mainline code

TAW
authored and
Brett Shirley (from Dev Box)
committed
Fixed missed removal of tchar.h

TAW
authored and
Brett Shirley (from Dev Box)
committed
Block Trim from running during Shrink (+ fix rank violation)

Alexandre Costa
authored and
Brett Shirley (from Dev Box)
committed
ESE Block Cache: fix cache failure under high load (such as eseutil /r)

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
ESE Block Cache: Write Caching Percentage fixes

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
Fix bad deref in non-revertable deleted table error event while trying to get table name.

Umair Ahmad
authored and
Brett Shirley (from Dev Box)
committed

Commits on Mar 9, 2026

A slew of JetInit and Failure Item diagnostic enhancements

Brett Shirley
authored and
Brett Shirley (from Dev Box)
committed
ESE Block Cache: Stability: FlushAllState on dismount crashes due to previous state

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
Disable Assert FaultItem type 2 with no inst

Brett Shirley
authored and
Brett Shirley (from Dev Box)
committed

Commits on Mar 10, 2026

ESE Block Cache: Perf: attach shouldn't consult cached file configuration if file cannot be attached

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed

Commits on May 13, 2026

ESE Block Cache: Perf: compress journal entries with LZ4

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed

Commits on May 16, 2026

ESE Block Cache: Perf: Extend IFileAPI::ErrFlushFileBuffers with FileFlushMode to enable data only flushes

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
This is a fast revert. The justification for the revert is: This set of changes is causing massive test failures, and already 77 M soft asserts in inner ring flooding optics.

Build Team
authored and
Brett Shirley (from Dev Box)
committed
This is a fast revert. The justification for the revert is: This set of changes is causing massive test failures, and already 77 M soft asserts in SDFv2 flooding optics.

Build Team
authored and
Brett Shirley (from Dev Box)
committed
ESE Block Cache: Perf: reduce ICacheConfiguration::PctWrite calls

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed

Commits on May 17, 2026

ESE: fix RFS for COSFile::ErrFlushFileBuffers

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
Fix various failures in ValidateTraceContextInEtwEvents test.

Umair Ahmad
authored and
Brett Shirley (from Dev Box)
committed
ESE Block Cache: TVS fixes for Windows

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
Added control of ESE's cache trace subsampling

Nathanael Cheriere
authored and
Brett Shirley (from Dev Box)
committed
ESE: Stability: fix hang during sync scavenge

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
BCrypt/CNG based implementation of AES256 compatible with the current CAPI implementation

Anil Ruia
authored and
Brett Shirley (from Dev Box)
committed
Raise corruption on hitting RBSFDPToBeDeleted based on variant

Vakishan
authored and
Brett Shirley (from Dev Box)
committed
Do not use -501 (JET_errLogFileCorrupt) error for logical corruption in log

Anil Ruia
authored and
Brett Shirley (from Dev Box)
committed
ESE Block Cache: Async IO Worker hang

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
Variant config setting to use new CNG AES256 implementation

Anil Ruia
authored and
Brett Shirley (from Dev Box)
committed
This is a fast revert. The justification for the revert is: This change is causing crashes in inner ring.

Build Team
authored and
Brett Shirley (from Dev Box)
committed
ESE Block Cache: fix the durability of IFileAPI::ErrFlushFileBuffers

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
Couple OACR fixes

Anil Ruia
authored and
Brett Shirley (from Dev Box)
committed

Commits on May 18, 2026

[Redo] A slew of JetInit and Failure Item diagnostic enhancement

Brett Shirley
authored and
Brett Shirley (from Dev Box)
committed
ESE Block Cache: Async IO Worker hang (redo)

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
Restructuring missed protecting the UlParam call against NULL pinst for instance specific parameter.

Brett Shirley
authored and
Brett Shirley (from Dev Box)
committed
ESE Block Cache: Perf: enable LZ4 compression for Journal Entries

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
Delete RCE in logical rather than allocation order

Anil Ruia
authored and
Brett Shirley (from Dev Box)
committed
ESE Block Cache: improve IO efficiency and general cleanup of CRequest

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
When doing fCleanOneDb, skip RCE for another database if already skipped earlier RCE in chain

Anil Ruia
authored and
Brett Shirley (from Dev Box)
committed
Perf: fix OSTraceEmit to use file append mode

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed

Commits on May 21, 2026

Refactor FCB creation, initialization and open 1/2

Umair Ahmad
authored and
Brett Shirley (from Dev Box)
committed
Fix eacr violation

Anil Ruia
authored and
Brett Shirley (from Dev Box)
committed
This is a fast revert due to inner ring stability issue.

Build Team
authored and
Brett Shirley (from Dev Box)
committed
Fix some asserts that hit in dbmaintstress.

Umair Ahmad
authored and
Brett Shirley (from Dev Box)
committed
ESE Block Cache: Stability: fix deadlock between write back and RegisterIFilePerfAPI

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
Move cbFree >= cbShrinkage enforce to PageEnforce so we get a page dump in .IRS.RAW

Brett Shirley
authored and
Brett Shirley (from Dev Box)
committed
ESE: fix ancient problem where we don't EnterDML during schema upgraders

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
ESE Block Cache: Perf: optimize use of Journal Slabs

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
Rolled back RCEs can appear out of order because Rollback does not always nullify RCEs in order

Anil Ruia
authored and
Brett Shirley (from Dev Box)
committed
JetDupSession2 to copy trxBegin0 for readonly transactions

Anil Ruia
authored and
Brett Shirley (from Dev Box)
committed
Revert: Change is causing test failures. This change had prev passed an ESE full test pass. The reverted PR age: 25.63 hours old.

Build Team
authored and
Brett Shirley (from Dev Box)
committed
ESE: Removing EBC tracing calls.

Nathanael Cheriere
authored and
Brett Shirley (from Dev Box)
committed
Add casts and some #defines preliminary to running GCR2

TAW
authored and
Brett Shirley (from Dev Box)
committed
ESE Block Cache: Perf: Combine slab updates for evict and cache

Andrew Goodsell
authored and
Brett Shirley (from Dev Box)
committed
Do not do dirty cache keep alive if we are close to checkpoint too deep limit at end of recovery

Anil Ruia
authored and
Brett Shirley (from Dev Box)
committed

Commits on May 22, 2026

Implement BBT buffer and associated data structures.

Umair Ahmad
authored and
Brett Shirley (from Dev Box)
committed
Refactor uses of CArray to use ErrAppendEntry(), FRemoveLastEntry() and Clear() whenever possible.

Alexandre Costa
authored and
Brett Shirley (from Dev Box)
committed
Fix the crash for pinst contextless memory failure tags.

Brett Shirley
authored and
Brett Shirley (from Dev Box)
committed
Do not try to delete preceding RCEs when the current RCE is a Delta RCE as the preceding one can be an uncommitted Delta RCE

Anil Ruia
authored and
Brett Shirley (from Dev Box)
committed
Hybrid Shrink phase 1: avoid breaking up contiguous leaf-page runs when moving data.

Alexandre Costa
authored and
Brett Shirley (from Dev Box)
committed