[PowerAccent] adding greek polytonic#47021
[PowerAccent] adding greek polytonic#47021guidotorresmx wants to merge 1 commit intomicrosoft:mainfrom
Conversation
|
@microsoft-github-policy-service agree |
| GD, | ||
| DE, | ||
| EL, | ||
| GRC, |
There was a problem hiding this comment.
ISO 639-3 defines GRC as the name for greek polytonic among others
| Language.GD => GetDefaultLetterKeyGD(letter), // Gàidhlig (Scottish Gaelic) | ||
| Language.DE => GetDefaultLetterKeyDE(letter), // German | ||
| Language.EL => GetDefaultLetterKeyEL(letter), // Greek | ||
| Language.GRC => GetDefaultLetterKeyGRC(letter), // Greek Polytonic |
There was a problem hiding this comment.
ISO 639-3 defines GRC as the name for greek polytonic among others
| Language.GD => GetDefaultLetterKeyGD(letter), // Gàidhlig (Scottish Gaelic) | ||
| Language.DE => GetDefaultLetterKeyDE(letter), // German | ||
| Language.EL => GetDefaultLetterKeyEL(letter), // Greek | ||
| Language.GRC => GetDefaultLetterKeyGRC(letter), // Greek Polytonic |
There was a problem hiding this comment.
ISO 639-3 defines GRC as the name for greek polytonic among others
| .Union(GetDefaultLetterKeyGD(letter)) | ||
| .Union(GetDefaultLetterKeyDE(letter)) | ||
| .Union(GetDefaultLetterKeyEL(letter)) | ||
| .Union(GetDefaultLetterKeyGRC(letter)) |
There was a problem hiding this comment.
ISO 639-3 defines GRC as the name for greek polytonic among others
| } | ||
|
|
||
| // Greek Polytonic | ||
| private static string[] GetDefaultLetterKeyGRC(LetterKey letter) |
There was a problem hiding this comment.
ISO 639-3 defines GRC as the name for greek polytonic among others
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, 👼 SARIF report, or 📝 job summary for details.Unrecognized words (1)GRC These words are not needed and should be removeddiu IPREVIEW ITHUMBNAIL LPCFHOOKPROC LUMA MAXDWORD MRT suntimes timespan traies udit VSyncTo accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the git@github.com:guidotorresmx/PowerToys.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/cfb6f7e75bbfc89c71eaa30366d0c166f1bd9c8c/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/24422628964/attempts/1' &&
git commit -m 'Update check-spelling metadata'If the flagged items are 🤯 false positivesIf items relate to a ...
|
Adds Greek Polytonic characters set to power accent, based on #29709
PR Checklist
Detailed Description of the Pull Request / Additional comments
Added all greek polytonic letters to their corresponding english letter (some duplicated)
(if you wondered about GRC -> ISO 639-3)
Validation Steps Performed
Compiled and Observed Power Accent