Skip to content

[PowerAccent] adding greek polytonic#47021

Open
guidotorresmx wants to merge 1 commit intomicrosoft:mainfrom
guidotorresmx:poweraccent-greek-polytonic
Open

[PowerAccent] adding greek polytonic#47021
guidotorresmx wants to merge 1 commit intomicrosoft:mainfrom
guidotorresmx:poweraccent-greek-polytonic

Conversation

@guidotorresmx
Copy link
Copy Markdown

@guidotorresmx guidotorresmx commented Apr 14, 2026

Adds Greek Polytonic characters set to power accent, based on #29709

PR Checklist

Detailed Description of the Pull Request / Additional comments

Added all greek polytonic letters to their corresponding english letter (some duplicated)
(if you wondered about GRC -> ISO 639-3)

Validation Steps Performed

Compiled and Observed Power Accent

@guidotorresmx
Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

@guidotorresmx guidotorresmx changed the title added greek polytonic base [PowerAccent] adding greek polytonic base Apr 14, 2026
@guidotorresmx guidotorresmx changed the title [PowerAccent] adding greek polytonic base [PowerAccent] adding greek polytonic Apr 14, 2026
GD,
DE,
EL,
GRC,
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ISO 639-3 defines GRC as the name for greek polytonic among others

Language.GD => GetDefaultLetterKeyGD(letter), // Gàidhlig (Scottish Gaelic)
Language.DE => GetDefaultLetterKeyDE(letter), // German
Language.EL => GetDefaultLetterKeyEL(letter), // Greek
Language.GRC => GetDefaultLetterKeyGRC(letter), // Greek Polytonic
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ISO 639-3 defines GRC as the name for greek polytonic among others

Language.GD => GetDefaultLetterKeyGD(letter), // Gàidhlig (Scottish Gaelic)
Language.DE => GetDefaultLetterKeyDE(letter), // German
Language.EL => GetDefaultLetterKeyEL(letter), // Greek
Language.GRC => GetDefaultLetterKeyGRC(letter), // Greek Polytonic
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ISO 639-3 defines GRC as the name for greek polytonic among others

.Union(GetDefaultLetterKeyGD(letter))
.Union(GetDefaultLetterKeyDE(letter))
.Union(GetDefaultLetterKeyEL(letter))
.Union(GetDefaultLetterKeyGRC(letter))
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ISO 639-3 defines GRC as the name for greek polytonic among others

}

// Greek Polytonic
private static string[] GetDefaultLetterKeyGRC(LetterKey letter)
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ISO 639-3 defines GRC as the name for greek polytonic among others

@github-actions
Copy link
Copy Markdown

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, 👼 SARIF report, or 📝 job summary for details.

Unrecognized words (1)

GRC

These words are not needed and should be removed diu IPREVIEW ITHUMBNAIL LPCFHOOKPROC LUMA MAXDWORD MRT suntimes timespan traies udit VSync

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the git@github.com:guidotorresmx/PowerToys.git repository
on the poweraccent-greek-polytonic branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/cfb6f7e75bbfc89c71eaa30366d0c166f1bd9c8c/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/24422628964/attempts/1' &&
git commit -m 'Update check-spelling metadata'
If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[PowerAccent] Adding Greek Polytonic characters set

2 participants