Fail fast on systemic SearchQA rollout failures#64
Open
summerview1997 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes SearchQA rollout fail fast when every item in a batch failed before the target agent produced any response.
Previously, per-item exceptions such as model endpoint misconfiguration were recorded as ordinary failed answers. If every item had
agent_ok=false, the trainer could continue with a complete-looking run and all-zero scores, even though no agent responses were produced.Changes
agent_ok=false.fail_reason.Impact
Infrastructure failures such as missing or unreachable model endpoints become visible immediately instead of being mistaken for model quality or skill optimization failure.
Validation
/home/thomas/SkillOpt/.venv/bin/python -m pytest -q tests/test_searchqa_rollout_failfast.py/home/thomas/SkillOpt/.venv/bin/python -m pytest -q/home/thomas/SkillOpt/.venv/bin/python -m ruff check skillopt/envs/searchqa/rollout.py tests/test_searchqa_rollout_failfast.py/home/thomas/SkillOpt/.venv/bin/python -m py_compile skillopt/envs/searchqa/rollout.py tests/test_searchqa_rollout_failfast.pygit diff --check