feat: add --no-check to advanced mock build-rpms (#444)

Author: tobiasb-ms

internal/app/azldev/cmds/advanced/mock.go

@@ -46,6 +46,8 @@ type BuildRPMOptions struct {
 	SRPMPath string
 	// Path to the output directory for final RPM files.
 	OutputDirPath string
+	// Whether to skip the %check section of the RPM spec.
+	NoCheck bool
 }
 
 // Constructs a [cobra.Command] for the "mock build-rpms" subcommand.
@@ -64,6 +66,7 @@ func NewBuildRPMCmd() *cobra.Command {
 	cmd.Flags().StringVarP(&options.MockConfigPath, "config", "c", "", "Path to the mock .cfg file")
 	cmd.Flags().StringVar(&options.SRPMPath, "srpm", "", "Path to the SRPM to build")
 	cmd.Flags().StringVarP(&options.OutputDirPath, "output-dir", "o", "", "Path to output directory")
+	cmd.Flags().BoolVar(&options.NoCheck, "no-check", false, "Skip package %check tests")
 
 	_ = cmd.MarkFlagRequired("srpm")
 	_ = cmd.MarkFlagRequired("output-dir")
@@ -114,7 +117,9 @@ func BuildRPMS(env *azldev.Env, options *BuildRPMOptions) (results interface{},
 		return results, err
 	}
 
-	buildOptions := mock.RPMBuildOptions{}
+	buildOptions := mock.RPMBuildOptions{
+		NoCheck: options.NoCheck,
+	}
 
 	evt := env.StartEvent("Building RPM with mock",
 		"srpmPath", options.SRPMPath, "outputDirPath", options.OutputDirPath)

internal/app/azldev/cmds/advanced/mock_test.go

@@ -62,6 +62,48 @@ func TestBuildRPMS(t *testing.T) {
 		require.Equal(t, true, result)
 	})
 
+	t.Run("NoCheck", func(t *testing.T) {
+		// Construct a new env with no configuration.
+		testEnv := testutils.NewTestEnv(t)
+
+		// Pretend that "mock" exists.
+		testEnv.CmdFactory.RegisterCommandInSearchPath("mock")
+
+		// Keep track of what commands get launched.
+		cmds := [][]string{}
+		testEnv.CmdFactory.RunHandler = func(cmd *exec.Cmd) error {
+			cmds = append(cmds, cmd.Args)
+
+			return nil
+		}
+
+		rpmOptions := &advanced.BuildRPMOptions{
+			MockCmdOptions: advanced.MockCmdOptions{
+				MockConfigPath: testMockConfigPath,
+			},
+			SRPMPath:      testSRPMPath,
+			OutputDirPath: testOutputDirPath,
+			NoCheck:       true,
+		}
+
+		result, err := advanced.BuildRPMS(testEnv.Env, rpmOptions)
+		require.NoError(t, err)
+		require.Equal(t, true, result)
+
+		// Verify that '--nocheck' was passed to mock.
+		found := false
+
+		for _, cmd := range cmds {
+			if slices.Contains(cmd, "mock") && slices.Contains(cmd, "--nocheck") {
+				found = true
+
+				break
+			}
+		}
+
+		require.True(t, found, "Expected '--nocheck' flag to be passed to mock")
+	})
+
 	t.Run("ValidProjectConfig", func(t *testing.T) {
 		testEnv := testutils.NewTestEnv(t)