Skip to content

Fix Microsoft Git Linux release asset compatibility - #130

Merged
Mark Phippard (markphip) merged 2 commits into
microsoft:mainfrom
scaryrawr:scaryrawr-microsoft-git-install-failure
Oct 20, 2026
Merged

Mark Phippard (markphip) merged 2 commits into
microsoft:mainfrom
scaryrawr:scaryrawr-microsoft-git-install-failure

Conversation

@scaryrawr

@scaryrawr Mike Wallio (scaryrawr) commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Summary

Microsoft Git 2.56.0.vfs.0.2 publishes Debian assets named microsoft-git_<version>_linux_<architecture>.deb, following the intentional naming change in microsoft/git#1001. The feature resolves the version correctly but requests older asset names, which return 404 and cause installation to fail before dpkg runs.

  • Try the current Linux-prefixed asset name first, then older architecture-specific names, then legacy packages on amd64 only.
  • Remove failed download files and report attempted package names if no download succeeds.
  • Install Mariner's rust package (which includes Cargo) for source builds: Git 2.56 builds its Rust library by default.
  • Bump the feature to 1.0.11 and document package compatibility.
  • Add pinned current/older release scenarios using the existing devcontainer testing infrastructure; no workflow changes or separate test framework.

Validation

Using the existing devcontainer features test runner with Docker:

  • All six scenarios pass on Linux amd64: exact 2.56.0.vfs.0.2 on Ubuntu 24.04, older architecture-specific package, latest stable, legacy amd64 package, partial multi-digit VFS version, and explicit prerelease.
  • The exact 2.56.0.vfs.0.2 scenario also passes on Linux arm64, including actual package installation and Git/Scalar checks.
  • The default feature test passes on Linux arm64 Ubuntu 24.04, including a real scalar clone.
  • Shell syntax, ShellCheck for the added scenario scripts, and diff checks pass.
  • CI at commit 4a108ef passes all jobs, including the native amd64 Mariner source build, Ubuntu, Debian, and all release scenarios: https://github.com/microsoft/codespace-features/actions/runs/39447249092

Based on upstream/main at e11832f. Only Microsoft Git feature files and scenarios are changed.

Support Linux-prefixed Debian release assets while retaining older architecture-specific and legacy amd64 package names. Add regression scenarios through the existing devcontainer test infrastructure.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 20, 2026 14:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused compatibility fix preserves architecture restrictions, includes regression scenarios, and has no identified blocking issues.

No open issues 🎉

What changed in this PR

Updates the Microsoft Git feature to support current Linux release asset names while retaining compatibility with older packages.

Changes:

  • Tries current, older architecture-specific, then amd64-only legacy packages; cleans failed downloads and reports attempted names.
  • Adds pinned scenarios checking Git versions and Scalar availability.
  • Documents package compatibility and bumps the feature to 1.0.11.
File Description
test/​microsoft-git/​scenarios.json Adds current and older release scenarios.
test/​microsoft-git/​old_arch_deb.sh Checks the older release and Scalar.
test/​microsoft-git/​linux_named_deb.sh Checks the current release and Scalar.
src/​microsoft-git/​NOTES.md Documents supported package naming formats.
src/​microsoft-git/​install.sh Updates download fallbacks, cleanup, and diagnostics.
src/​microsoft-git/​devcontainer-feature.json Bumps the feature to 1.0.11.

Review effort: Balanced

Git 2.56 builds its Rust library by default. Mariner's rust package supplies both rustc and cargo, matching the source build prerequisites without disabling Rust support.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 20, 2026 15:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No blocking issues remain, and reported validation covers fallback ordering, cleanup, architecture restrictions, and installation compatibility.

No open issues 🎉

Review effort: Balanced

@markphip
Mark Phippard (markphip) merged commit 80691b5 into microsoft:main Oct 20, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants