Repository navigation
Conversation
sean0407
requested review from
Paul Dorsch (pauld-msft)
and
a balanced review from Copilot
October 20, 2026 20:06
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new precedence can suppress positive AOT signals and misclassify self-contained inner builds.
2 open issues
What changed in this PR
This PR addresses #1893 by making explicit binlog self-containment values override the NuGet lock-file heuristic.
Changes:
- Adds a nullable binlog decision to distinguish explicit false from missing information.
- Adds regression coverage for framework-dependent libraries with runtime-pack downloads.
| File | Description |
|---|---|
| test/Microsoft.ComponentDetection.Detectors.Tests/nuget/MSBuildBinaryLogComponentDetectorTests.cs | Adds the explicit-false regression and runtime-pack fixture. |
| src/Microsoft.ComponentDetection.Detectors/nuget/MSBuildBinaryLogComponentDetector.cs | Prioritizes explicit binlog values over lock-file inference. |
Review effort: Balanced
| private static bool IsSelfContainedFromProjectInfo(MSBuildProjectInfo projectInfo) => | ||
| projectInfo.SelfContained == true || projectInfo.PublishAot == true; | ||
| private static bool? IsSelfContainedFromProjectInfo(MSBuildProjectInfo projectInfo) => | ||
| projectInfo.SelfContained ?? (projectInfo.PublishAot == true ? true : null); |
| var innerInfo = GetInnerBuildOrDefault(projectInfo, target.TargetFramework); | ||
| var targetType = GetTargetType(innerInfo.OutputType); | ||
| var isSelfContained = isSelfContainedFromBinlog || | ||
| var isSelfContained = isSelfContainedFromBinlog ?? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SelfContainedvalue from the MSBuild binlog before considering the lock-file heuristic; retainPublishAot=trueas a positive self-contained signal.Fixes #1893
Reproduction
A library with
SelfContained=falsecan still haveMicrosoft.NETCore.App.Runtime.*download dependencies in its assets file. With that lock-file metadata and an explicit false binlog value, the detector previously reportedlibrary-selfcontained; it should reportlibrary. The regression test exercises that metadata and binlog combination.Changed files
src/Microsoft.ComponentDetection.Detectors/nuget/MSBuildBinaryLogComponentDetector.cstest/Microsoft.ComponentDetection.Detectors.Tests/nuget/MSBuildBinaryLogComponentDetectorTests.csValidation
git diff --checkpassed.