Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions deps/ntfind/src/buffer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -226,9 +226,9 @@ impl BufferStream {
// find.exe would transparently use memory mapping for `FILE_TYPE_DISK` (see `FILE_STREAM::Initialize`).
// This doesn't work well with Rust, as we cannot handle the `EXCEPTION_IN_PAGE_ERROR` SEH exception.
// That's not a problem. ulib is quite poorly written and we can outperform it with `ReadFile` anyway.
// `(Rtl)IsTextUnicode` also only inspects the first 256 bytes, so `ReadFile` doesn't loose us anything.
// `(Rtl)IsTextUnicode` also only inspects the first 256 bytes, so `ReadFile` doesn't lose us anything.
//
// Why does this matter? Because ulib contains two distinct and separat copies of the `RtlIsTextUnicode`
// Why does this matter? Because ulib contains two distinct and separate copies of the `RtlIsTextUnicode`
// logic and their flags subtly differ. There's no explanation in the code why that is.
//
// NOTE that technically ulib also checks the file size and restricts mmap to <3GiB.
Expand Down
2 changes: 1 addition & 1 deletion deps/ntsort/sort.c
Original file line number Diff line number Diff line change
Expand Up @@ -2262,7 +2262,7 @@ run_t *tree_insert(run_t *run, int not_empty)

winner = (not_empty ? run : END_OF_RUN);

/* start at the bottom of the tournament tree, work up the the top
/* start at the bottom of the tournament tree, work up the top
* comparing the current winner run with the runs on the path to the
* top of the tournament tree.
*/
Expand Down