Repository navigation
chore(storybook): upgrade to 10.6.3 for Nx 23 compatibility - #684
Open
Paul Mardling (PaulGMardling) wants to merge 3 commits into
Open
Paul Mardling (PaulGMardling) wants to merge 3 commits into
Paul Mardling (PaulGMardling) wants to merge 3 commits into
Conversation
Preserve Nx 22 and existing library/Jest settings while migrating Storybook configuration and story integration checks to export-aware module resolution. Retain the previous synthetic-default-import behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45985d00-bee2-46cc-b076-f90fa40a3cc3
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45985d00-bee2-46cc-b076-f90fa40a3cc3
Apply the repository's highest-resolution dedupe strategy so the Storybook upgrade satisfies the CI lockfile check. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45985d00-bee2-46cc-b076-f90fa40a3cc3
Paul Mardling (PaulGMardling)
marked this pull request as ready for review
October 22, 2026 14:16
Paul Mardling (PaulGMardling)
requested review from
a team,
Dmytro Kirpa (dmytrokirpa),
Hector Jimenez (hectorjjb),
Victor Genaev (mainframev) and
Sean Monahan (spmonahan)
as code owners
October 22, 2026 14:16
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade Storybook from 9.1.16 to 10.6.3 as a separate prerequisite for the Nx 23 upgrade. Nx remains at 22.7.7 in this PR so the Storybook migration can be reviewed and validated independently.
moduleResolution: "bundler"only in Storybook and React 17/18/19 story-integration configurations. Explicitly retainallowSyntheticDefaultImports: falseto preserve the previous import-checking behavior; shared library and Jest settings are unchanged.yarn run dedupecommand to satisfy the CI lockfile check.noneBeachball change for the CAP theme's development-only addon update. No component implementation or public API changes are included.Why a major Storybook update?
Nx 23's build and dev executors dynamically import
storybook/internal/core-server. Storybook 9.1.16 works through CommonJSrequire(), but its ESM entry fails withDynamic require of "path" is not supported.The same failure was reproduced with Storybook 9.1.21 on Node 22.23.1 and 24.18.0, so the latest 9.x patch did not resolve the incompatibility. Storybook 10.0.0 and the selected 10.6.3 release expose the
buildfunction through both loading paths on those runtimes.Validation
Local validation of the final deduplicated dependency graph:
yarn run dedupe --check --json,yarn install --immutable,yarn check-dependencies, and Beachball checks pass.The existing integration prerequisite build/type-check targets also passed for 24 projects during the migration. This PR does not upgrade Nx or claim full Nx 23 integration validation; that remains separate work.