CWCOW: Logging enforcement#2728
Draft
MahatiC wants to merge 2 commits into
Draft
Conversation
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
This commit adds guest-side enforcement: each requested ETW provider is validated against allowed_log_providers declared in the security policy (case-insensitive match). Providers not in the allowlist are silently dropped. The filtered config is re-encoded and forwarded to GCS with GUIDs resolved. Also removes the hostedSystemConfig dead code path from createContainer — the sidecar only runs for confidential containers, which always use CWCOWHostedSystem. Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
KenGordon
reviewed
May 11, 2026
Collaborator
KenGordon
left a comment
KenGordon
left a comment
There was a problem hiding this comment.
Can you see if there are any other missing enforcement points we should know about?
| defer span.End() | ||
| defer func() { oc.SetSpanStatus(span, err) }() | ||
|
|
||
| // Todo: Add policy enforcement for modifying service settings |
Collaborator
There was a problem hiding this comment.
Is this safe? It doesn't sound like it from the comment here or the log at line 609.
Member
Author
There was a problem hiding this comment.
Yeah, I don't think we need to do that (I didn't write that comment, so not sure what was the intention for this)
Member
Author
I've addressed the ones that I had noted before (and the one pointed by Tingmao). I don't think anything else is missing. I responded the the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds guest-side enforcement: each requested ETW provider is validated against allowed_log_providers declared in the security policy (case-insensitive match).
Providers not in the allowlist are silently dropped. The filtered config is re-encoded and forwarded to GCS with GUIDs resolved.
Also removes the hostedSystemConfig dead code path from createContainer — the sidecar only runs for confidential containers, which always use CWCOWHostedSystem.