guest/spec: remove VirtualPod path helpers and dead code#2736
Open
shreyanshjain7174 wants to merge 1 commit into
Open
guest/spec: remove VirtualPod path helpers and dead code#2736shreyanshjain7174 wants to merge 1 commit into
shreyanshjain7174 wants to merge 1 commit into
Conversation
rawahars
approved these changes
May 12, 2026
Remove 13 VirtualPod-specific path functions from spec.go that are no longer called after the pod unification. All callers now use the *FromRoot variants added in microsoft#2653. Also removes SandboxLogsDir and SandboxLogPath — both were only reachable through VirtualPodAwareSandboxRootDir which is now gone. Updates ExtendPolicyWithNetworkingMounts in pkg/securitypolicy to accept a sandboxRoot string and use the FromRoot variant. Signed-off-by: Shreyansh Sancheti <shsancheti@microsoft.com>
shreyanshjain7174
force-pushed
the
guest-cleanup-virtual-pod
branch
from
e7b5238 to
ab47712
Compare
rawahars
approved these changes
May 13, 2026
Contributor
|
@anmaxvl Can you check once as well since there is a change to one of the methods used in confidential workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2699: removes the VirtualPod-specific path helpers from internal/guest/spec/spec.go that became dead code after the pod-unification refactor.
Context
After #2699, all callers of pod paths use the *FromRoot(sandboxRoot) variants from #2653. The 13
Get*VirtualPod*/VirtualPodAware*helpers in spec.go are no longer reachable from any production path, andSandboxLogsDir/SandboxLogPathwere only used byVirtualPodAwareSandboxRootDir.Changes
internal/guest/spec/spec.go.SandboxLogsDirandSandboxLogPath.ExtendPolicyWithNetworkingMountsinpkg/securitypolicyto takesandboxRoot stringand use the FromRoot variant.Stats
4 files changed, 21 insertions(+), 167 deletions(-).
Depends on #2699.