You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
add build_and_push and update_service tools - #198
Track command results and private-session execution ownership for resumable service maintenance. Delegate Cilium publication with image preflight, grouped progress and manifest updates. Include focused regressions and usage documentation.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Hold a nonblocking workflow lock across progress reset, builds and pushes. Reject mismatched Agent and Operator versions before publication. Add focused regression coverage and document both safeguards.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ask for explicit approval before updating Cilium deployment references after publication. Record declined updates as published, fail on unavailable confirmation input, and keep batch resume consistent. Remove batch and publisher locks in favor of user-managed concurrency; update regressions and README.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Retain node objects to prevent recycled IDs causing false aliases
src/cilium/build/push.sh:79
The alias detector stores only integer object IDs. As compose_all advances through the production manifest's many YAML documents, nodes from older documents can be collected and their IDs reused, causing a valid later node to be reported as an alias. Retain the node objects themselves so their identities cannot be recycled during traversal.
Reuse registry authentication across per-image pushes
tools/build_and_push_images.sh:347
Each non-Cilium image starts a new pai_build.py push, whose push_center() unconditionally performs Azure account/ACR checks and an ACR login before pushing. With dozens of tasks this repeats the registry authentication workflow once per image, adding substantial latency and throttling risk. Authenticate once for the batch or provide a reusable/no-login per-image push path while retaining progress checkpoints.
Reject --from values beyond the discovered task count
tools/build_and_push_images.sh:447
--from accepts any positive integer, but values greater than the discovered task count make every task hit the skip branch and the command exits successfully without building or pushing anything. Validate the requested step against ${#TASKS[@]} after discovery so a typo cannot be reported as a successful workflow.
Persist the Cilium manifest snapshot across resumed runs
tools/updatePaiService.py:450
The Cilium manifest copy lives only in this invocation's temporary directory. If delete succeeds and apply fails, a resumed run skips the delete but recreates this copy from whatever manifest is currently in the worktree, so it may apply a different resource set than the one it deleted. Persist and reuse a run-scoped manifest snapshot until both Cilium steps complete.
Reject out-of-range resume steps before resetting progress or executing image commands. Include captured failure diagnostics while withholding raw kubeconfig stdout. Add regression coverage and update usage documentation.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Scope YAML node identity tracking to each document and cover the multi-document deployment manifest in publication regression tests.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Clarify intentional source-hash stripping for all three images and cover republishing different image IDs under the same version-date tags.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Treat ProcessLookupError as a vanished procfs identity, add regression coverage, and focus the maintenance README on script usage and operational cautions.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove the kubeconfig snapshot and environment override, call paictl without -c, and document caller responsibility for configuration consistency. Update recovery coverage for inherited configuration behavior.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove prometheus/prometheus from the batch image exclusion list and update the documented exclusions. Keep all other exclusions unchanged.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add build_and_push and update_service tools